From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Shuo Wang <wangshuo47@huawei.com>
Cc: patchwork-bot@kernel.org,
linux-modules <linux-modules@vger.kernel.org>,
hushiyuan@huawei.com
Subject: Re: [PATCH] libkmod: assign values to variables to fix warnings
Date: Sat, 23 Jan 2021 11:04:06 -0800 [thread overview]
Message-ID: <CAKi4VALZ9ymom6-7ry++0cVPQTC2UhUqv8QU30kXpuR3dUG=Lg@mail.gmail.com> (raw)
In-Reply-To: <20210121070627.17072-1-wangshuo47@huawei.com>
On Wed, Jan 20, 2021 at 11:06 PM Shuo Wang <wangshuo47@huawei.com> wrote:
>
>
> Dear Lucas,
>
> Thanks for your reply. I was wondering if these changes will
> be merged in the future?
It seems those errors are actually compiler mistakes. Aren't there
updates to the compiler? What distro is shipping gcc 7.3.0??
See below.
>
> Best regards,
> Shuo
>
> >gcc version 7.3.0 (GCC)
> >
> >>what compiler?
> >>>libkmod/libkmod.c: In function 'kmod_lookup_alias_is_builtin':
> >>>./shared/util.h:73:9: warning: 'line' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>> free(*(void**) p);
> >>> ^~~~~~~~~~~~~~~~~
> >>>libkmod/libkmod.c:581:23: note: 'line' was declared here
> >>> _cleanup_free_ char *line;
> >>> ^~~~
> >>>In file included from libkmod/libkmod-module.c:42:0:
> >>>libkmod/libkmod-module.c: In function 'kmod_module_probe_insert_module':
> >>>./shared/util.h:73:9: warning: 'cmd' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>> free(*(void**) p);
> >>> ^~~~~~~~~~~~~~~~~
> >>>libkmod/libkmod-module.c:1009:23: note: 'cmd' was declared here
> >>> _cleanup_free_ char *cmd;
> >>>
> >>>---
> >>> libkmod/libkmod-module.c | 2 +-
> >>> libkmod/libkmod.c | 2 +-
> >>> 2 files changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>>diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
> >>>index 76a6dc3..2e973b5 100644
> >>>--- a/libkmod/libkmod-module.c
> >>>+++ b/libkmod/libkmod-module.c
> >>>@@ -1006,7 +1006,7 @@ static int module_do_install_commands(struct kmod_module *mod,
> >>> {
> >>> const char *command = kmod_module_get_install_commands(mod);
> >>> char *p;
> >>>- _cleanup_free_ char *cmd;
> >>>+ _cleanup_free_ char *cmd = NULL;
> >>> int err;
> >>> size_t cmdlen, options_len, varlen;
> >>>
> >>>diff --git a/libkmod/libkmod.c b/libkmod/libkmod.c
> >>>index 43423d6..66e658c 100644
> >>>--- a/libkmod/libkmod.c
> >>>+++ b/libkmod/libkmod.c
> >>>@@ -578,7 +578,7 @@ finish:
> >>>
> >>> bool kmod_lookup_alias_is_builtin(struct kmod_ctx *ctx, const char *name)
> >>> {
> >>>- _cleanup_free_ char *line;
> >>>+ _cleanup_free_ char *line = NULL;
> >>>
> >>> line = lookup_builtin_file(ctx, name);
line is declared above and just assigned here, the initial NULL makes
no difference.
Lucas De Marchi
> >>>
> >>>--
> >>>2.23.0
next prev parent reply other threads:[~2021-01-23 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 7:06 [PATCH] libkmod: assign values to variables to fix warnings Shuo Wang
2021-01-23 19:04 ` Lucas De Marchi [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-11 14:13 Shuo Wang
2021-01-08 7:22 Shuo Wang
2021-01-11 13:09 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKi4VALZ9ymom6-7ry++0cVPQTC2UhUqv8QU30kXpuR3dUG=Lg@mail.gmail.com' \
--to=lucas.de.marchi@gmail.com \
--cc=hushiyuan@huawei.com \
--cc=linux-modules@vger.kernel.org \
--cc=patchwork-bot@kernel.org \
--cc=wangshuo47@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).