From: Lucas De Marchi <lucas.de.marchi@gmail.com>
To: Jessica Yu <jeyu@kernel.org>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
linux-modules <linux-modules@vger.kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
Giovanni Gherdovich <ggherdovich@suse.cz>
Subject: Re: [PATCH 2/4] libkmod-config: re-quote option from kernel cmdline
Date: Mon, 15 Feb 2021 12:18:15 -0800 [thread overview]
Message-ID: <CAKi4VALw-mOh6e0agvQyjfV4Whh1s9POZ7iX8RQUZSV2m=NxuA@mail.gmail.com> (raw)
In-Reply-To: <YCqTOzfcWkbguKDO@gunter>
On Mon, Feb 15, 2021 at 7:33 AM Jessica Yu <jeyu@kernel.org> wrote:
>
> +++ Lucas De Marchi [12/02/21 01:45 -0800]:
> >It was reported that grub mangles the kernel cmdline. It turns
> >
> > acpi_cpufreq.dyndbg="file drivers/cpufreq/acpi-cpufreq.c +mpf"
> >
> > into
> >
> > "acpi_cpufreq.dyndbg=file drivers/cpufreq/acpi-cpufreq.c +mpf"
> >
> >However, even though we could blame grub for doing that, the kernel
> >happily accepts and re-quotes it when the module is built-in.
> >So, it's better if kmod also understands it this way and does the same.
> >
> >Here we basically add additional code to un-mangle it, moving the quote
> >in way that is acceptable to pass through init_module(). Note that the
> >interface [f]init_module() gives us mandates the quote to be part of the
> >value: the module name is not passed and the options are separated by
> >space.
> >
> >Reported-by: Jiri Slaby <jirislaby@kernel.org>
> >Link: https://bugzilla.suse.com/show_bug.cgi?id=1181111#c10
>
> Hi Lucas,
>
> Thanks a lot for working on this. I applied this patchset on top of
> kmod master and after some light testing it appears to be able to
> handle the mangled quoting from grub now:
>
> Tested-by: Jessica Yu <jeyu@kernel.org>
thanks!
Applied
Lucas De Marchi
next prev parent reply other threads:[~2021-02-15 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 9:45 [PATCH 1/4] libkmod-config: revamp kcmdline parsing into a state machine Lucas De Marchi
2021-02-12 9:45 ` [PATCH 2/4] libkmod-config: re-quote option from kernel cmdline Lucas De Marchi
2021-02-15 15:28 ` Jessica Yu
2021-02-15 20:18 ` Lucas De Marchi [this message]
2021-02-12 9:45 ` [PATCH 3/4] testsuite: allow to re-use single function for tests Lucas De Marchi
2021-02-12 9:45 ` [PATCH 4/4] test-modprobe: share single function for kcmdline tests Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKi4VALw-mOh6e0agvQyjfV4Whh1s9POZ7iX8RQUZSV2m=NxuA@mail.gmail.com' \
--to=lucas.de.marchi@gmail.com \
--cc=ggherdovich@suse.cz \
--cc=jeyu@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).