linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jessica Yu <jeyu@kernel.org>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: masahiroy@kernel.org, linux-modules@vger.kernel.org,
	linux-kernel@vger.kernel.org, arnd@arndb.de,
	Eugene Loh <eugene.loh@oracle.com>,
	Kris Van Hees <kris.van.hees@oracle.com>
Subject: Re: [PATCH v2 PING] kallsyms: new /proc/kallmodsyms with builtin modules and symbol sizes
Date: Thu, 8 Jul 2021 10:40:13 +0200	[thread overview]
Message-ID: <YOa57bMUbUlxJ5Mv@p200300cbcf044300404ca642de146c7c.dip0.t-ipconnect.de> (raw)
In-Reply-To: <87lf6ic58x.fsf@esperi.org.uk>

+++ Nick Alcock [07/07/21 20:07 +0100]:
>On 7 Jul 2021, Jessica Yu uttered the following:
>
>> +++ Nick Alcock [06/07/21 20:33 +0100]:
>>> 15 files changed, 1309 insertions(+), 67 deletions(-)
>>
>> This diffstat is seriously _enormous_. Please don't send patches of
>> this size and expect people to be willing to review :-(. Please break
>> this up into a logical sequence of smaller patches to help your
>> potential reviewers and resend with a cover letter.
>
>Heh, this is very project-dependent it seems. I've been told not to
>split up things so finely when sending series containing 3000+-line
>commits to various toolchain projects before :)

Huh, that's interesting :) 

>Since you are in the "slice finely" camp, I'll split it up a bunch and
>resend. (This will necessarily involve adding things in one commit to
>no obvious purpose in that commit, but I'll keep the intermediate stages
>building and booting, of course.)

Yes, the norm in the Linux kernel community is to split up large
patches into a logical sequence of smaller patches, this will help
reviewers a lot. Thanks in advance!


      reply	other threads:[~2021-07-08  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210629221542.93728-1-nick.alcock@oracle.com>
2021-07-06 19:33 ` [PATCH v2 PING] kallsyms: new /proc/kallmodsyms with builtin modules and symbol sizes Nick Alcock
2021-07-07 14:56   ` Jessica Yu
2021-07-07 19:07     ` Nick Alcock
2021-07-08  8:40       ` Jessica Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOa57bMUbUlxJ5Mv@p200300cbcf044300404ca642de146c7c.dip0.t-ipconnect.de \
    --to=jeyu@kernel.org \
    --cc=arnd@arndb.de \
    --cc=eugene.loh@oracle.com \
    --cc=kris.van.hees@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).