From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A11C4320A for ; Wed, 4 Aug 2021 17:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1803261037 for ; Wed, 4 Aug 2021 17:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238283AbhHDR7O (ORCPT ); Wed, 4 Aug 2021 13:59:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237302AbhHDR7N (ORCPT ); Wed, 4 Aug 2021 13:59:13 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A080C0613D5; Wed, 4 Aug 2021 10:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=f05KDrtHywJ7ptgF5rdbcaksmjyPJirEWKVIlatL5dQ=; b=ZyInXTn6AUJn5/Nm0+ZZKIe/dw AIYzDU9oMm85lKCsFXkMZcLEI3tUpqtdDmQEr/f1FLo63q7sSG7yxzHzPHeamw2fd5QEIW+kizVE/ fDQroRDkJvmQlIlm10Mc0GOZw/s7LWS4ZxHksbo+s0OelZXS17g/C50ngyawEkK0B32reP/1udCWc vjC/nSD4k/XHMxKDH+TYvkmSc06J3qBTIJYkOnt05eBZag/g4x+hoCcQJznJkvMmO7qxb9WP+ej82 1RFeEdQmo8H1frJgEoOI91do5nV5KA2/btmeOW3q7NV3aZ7z3EW2idz/bF5bJUKwE7WWW6KGaxjA2 HWFhB1mQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBLAR-00771T-Fk; Wed, 04 Aug 2021 17:58:59 +0000 Date: Wed, 4 Aug 2021 10:58:59 -0700 From: Luis Chamberlain To: lucas.demarchi@intel.com, linux-modules@vger.kernel.org Cc: live-patching@vger.kernel.org, fstests@vger.kernel.org, linux-block@vger.kernel.org, hare@suse.de, dgilbert@interlog.com, jeyu@kernel.org, osandov@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] libkmod-module: add support for a patient module removal option Message-ID: References: <20210803202417.462197-1-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210803202417.462197-1-mcgrof@kernel.org> Sender: Luis Chamberlain Precedence: bulk List-ID: On Tue, Aug 03, 2021 at 01:24:17PM -0700, Luis Chamberlain wrote: > + diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c <-- snip --> > + ERR(mod->ctx, "%s refcnt is %ld waiting for it to become 0\n", mod->name, refcnt); OK after running many tests with this I think we need to just expand this so that the error message only applies when -v is passed to modprobe, otherwise we get the print message every time, and using INFO() doesn't cut it, given the next priority level available to the library is LOG_INFO (6) and when modprobe -v is passed we set the log level to LOG_NOTICE (5), so we need a new NOTICE(). I'll send a v2 with that included as a separate patch. Luis