linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: cl@linux.com, pmladek@suse.com, mbenes@suse.cz,
	akpm@linux-foundation.org, jeyu@kernel.org,
	linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	atomlin@atomlin.com, ghalat@redhat.com
Subject: Re: [RFC PATCH 05/12] module: Move arch strict rwx support to a separate file
Date: Wed, 12 Jan 2022 08:13:02 -0800	[thread overview]
Message-ID: <Yd7+DnFiuklVScmI@bombadil.infradead.org> (raw)
In-Reply-To: <20211228213041.1356334-6-atomlin@redhat.com>

On Tue, Dec 28, 2021 at 09:30:34PM +0000, Aaron Tomlin wrote:
> diff --git a/kernel/module/Makefile b/kernel/module/Makefile
> index 9d593362156d..95fad95a0549 100644
> --- a/kernel/module/Makefile
> +++ b/kernel/module/Makefile
> @@ -8,3 +8,4 @@ obj-$(CONFIG_MODULE_SIG) += signing.o
>  obj-$(CONFIG_MODULE_SIG_FORMAT) += signature.o
>  obj-$(CONFIG_LIVEPATCH) += livepatch.o
>  obj-$(CONFIG_MODULES_TREE_LOOKUP) += tree_lookup.o
> +obj-$(CONFIG_ARCH_HAS_STRICT_MODULE_RWX) += arch_strict_rwx.o
> diff --git a/kernel/module/arch_strict_rwx.c b/kernel/module/arch_strict_rwx.c
> new file mode 100644
> index 000000000000..68e970671ec5
> --- /dev/null
> +++ b/kernel/module/arch_strict_rwx.c
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * kernel/module/arch_strict_rwx.c - module arch strict rwx

No need to repeat the name of the file, a simple:

+ * module arch strict rwx

Would do it.

Please get 0day to test your git tree as you work on it, and before
posting patches ensure they get tested by 0day, so we run into less
issues once merged into modules-next.

  Luis

  reply	other threads:[~2022-01-12 16:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 17:33 [RFC PATCH] module: Introduce module unload taint tracking Aaron Tomlin
2021-12-08 20:47 ` Luis Chamberlain
2021-12-09 16:49   ` Aaron Tomlin
2021-12-09 23:42     ` Luis Chamberlain
2021-12-10 10:00       ` Petr Mladek
2021-12-10 16:09         ` Aaron Tomlin
2021-12-10 17:09           ` Luis Chamberlain
2021-12-13 15:16           ` Petr Mladek
2021-12-21 11:58             ` Aaron Tomlin
2021-12-10 17:03         ` Luis Chamberlain
2021-12-10 15:48       ` Aaron Tomlin
2021-12-28 21:30       ` [RFC PATCH 00/12] module: core code clean up Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 01/12] module: Move all into module/ Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 02/12] module: Simple refactor in preparation for split Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 03/12] module: Move livepatch support to a separate file Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 04/12] module: Move latched RB-tree " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 05/12] module: Move arch strict rwx " Aaron Tomlin
2022-01-12 16:13           ` Luis Chamberlain [this message]
2021-12-28 21:30         ` [RFC PATCH 06/12] module: Move " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 07/12] module: Move extra signature support out of core code Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 08/12] module: Move kmemleak support to a separate file Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 09/12] module: Move kallsyms support into " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 10/12] module: Move procfs " Aaron Tomlin
2021-12-28 21:30         ` [RFC PATCH 11/12] module: Move sysfs " Aaron Tomlin
2022-01-12 16:20           ` Luis Chamberlain
2021-12-28 21:30         ` [RFC PATCH 12/12] module: Move kdb_modules list out of core code Aaron Tomlin
2021-12-29  8:58         ` [RFC PATCH 00/12] module: core code clean up Aaron Tomlin
2022-01-12 16:21         ` Luis Chamberlain
2021-12-13 13:00     ` [RFC PATCH] module: Introduce module unload taint tracking Allen
2021-12-20 19:23       ` Luis Chamberlain
2021-12-21 11:44       ` Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd7+DnFiuklVScmI@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=atomlin@redhat.com \
    --cc=cl@linux.com \
    --cc=ghalat@redhat.com \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).