From: Luis Chamberlain <mcgrof@kernel.org>
To: Saravana Kannan <saravanak@google.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
kernel-team@android.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org
Subject: Re: [PATCH v1] module: Add support for default value for module async_probe
Date: Fri, 3 Jun 2022 08:01:46 -0700 [thread overview]
Message-ID: <YpoiWhMqANChE/ph@bombadil.infradead.org> (raw)
In-Reply-To: <20220603055442.521888-1-saravanak@google.com>
On Thu, Jun 02, 2022 at 10:54:41PM -0700, Saravana Kannan wrote:
> Add a module.async_probe kernel command line option that allows enabling
> async probing for all modules. When this command line option is used,
> there might still be some modules for which we want to explicitly force
> synchronous probing, so extend <modulename>.async_probe to take an
> optional bool input so that async probing can be disabled for a specific
> module.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 8 ++++++--
> kernel/module/main.c | 11 ++++++++++-
> 2 files changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 710b52d87bdd..32083056bd25 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -1147,8 +1147,12 @@
> nopku [X86] Disable Memory Protection Keys CPU feature found
> in some Intel CPUs.
>
> - <module>.async_probe [KNL]
> - Enable asynchronous probe on this module.
> + <module>.async_probe[=<bool>] [KNL]
> + If no <bool> value is specified or if the value
> + specified is not a valid <bool>, enable asynchronous
> + probe on this module. Otherwise, enable/disable
> + asynchronous probe on this module as indicated by the
> + <bool> value.
The commit log says a bit more. Can you clarify this on the
documentation?
We should strive slowly towards more async probes. This will take
time. To help with further then a Kconfig option which sets this
to a default to true if enabled would be useful so that no kernel
parameter is needed at all to set the default. Then you can
override the default, and blacklist each driver as well.
Luis
next prev parent reply other threads:[~2022-06-03 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 5:54 [PATCH v1] module: Add support for default value for module async_probe Saravana Kannan
2022-06-03 15:01 ` Luis Chamberlain [this message]
2022-06-03 23:16 ` Saravana Kannan
2022-07-01 22:15 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpoiWhMqANChE/ph@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).