From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F4C2C6FD1C for ; Mon, 20 Mar 2023 21:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230025AbjCTV3Q (ORCPT ); Mon, 20 Mar 2023 17:29:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbjCTV3P (ORCPT ); Mon, 20 Mar 2023 17:29:15 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD2416A46; Mon, 20 Mar 2023 14:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7+GIdFmD772nNedNSRkfi5ehiQ4I311T7kzgXJ4QrMI=; b=sdd+uQCb3+gOEFA3jSVzOgU6wv r451TRpy2eQjyp394rh+54wTxOC6aLhl0S6J6sSsU0PCS5zhjDUxBFHfVcbdVv+Q623IBv174WKiO x3L592ne+u4C4CH9TRoCQh3s/cmaeNvMLM10N9jWD5LxoUWHeK5nRsEjlzJ2p6pThTdAHtie+oJYU DA0fdvptbbwpgow7G9Hhgs6kAUakCHhIhQJEuWyNon7uFu96TjLPKDkpw/rAiiScV7/QIb724sA96 fGxw6LmJu/RXsb1b4qMtNbBsypPwzM7FvRnMnwAAANlki5VtvkX/ZYE59h6O5q5CIf9tBLtfOrRu+ hqPqzFmA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1peN2D-00AXVD-1m; Mon, 20 Mar 2023 21:27:17 +0000 Date: Mon, 20 Mar 2023 14:27:17 -0700 From: Luis Chamberlain To: David Hildenbrand , Adam Manzanares Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, pmladek@suse.com, petr.pavlu@suse.com, prarit@redhat.com, christophe.leroy@csgroup.eu, song@kernel.org, torvalds@linux-foundation.org Subject: Re: [RFC 00/12] module: avoid userspace pressure on unwanted allocations Message-ID: References: <2bd995a7-5b7f-59a1-751e-c56e76a7d592@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: On Mon, Mar 20, 2023 at 02:23:36PM -0700, Luis Chamberlain wrote: > On Mon, Mar 20, 2023 at 10:15:23PM +0100, David Hildenbrand wrote: > > Not able to reproduce with 20230319-module-alloc-opts so far (2 tries). > > Oh wow, so to clarify, it boots OK? > Now that we know that tree works, I'm curious also now if you can confirm just re-ordering the patches still works (it should) https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=20230319-module-alloc-opts-adjust And although it's *probably* just noise, but I'm very curious how much, if any difference there is if you just revert "module: use list_add_tail_rcu() when adding module". The data on that commit log is pretty small as I have a low end system, and I'm not yet done beating the hell out of a system with stress-ng, but getting some data froma pretty large system would be great. Specially if this series seems to prove fixing boot on them. Luis