From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B51C19F2D for ; Sat, 6 Aug 2022 13:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229852AbiHFN1n (ORCPT ); Sat, 6 Aug 2022 09:27:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbiHFN1n (ORCPT ); Sat, 6 Aug 2022 09:27:43 -0400 X-Greylist: delayed 925 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 06 Aug 2022 06:27:42 PDT Received: from matoro.tk (unknown [IPv6:2600:1700:4b10:9d80::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50403DFE0 for ; Sat, 6 Aug 2022 06:27:42 -0700 (PDT) DKIM-Signature: a=rsa-sha256; bh=NgjIxfiLr9uAbAmk3wWQnrtGLQCUOPaOTT5Oe/ZeRt0=; c=relaxed/relaxed; d=matoro.tk; h=Subject:Subject:Sender:To:To:Cc:Cc:From:From:Date:Date:MIME-Version:MIME-Version:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Reply-To:In-Reply-To:In-Reply-To:Message-Id:Message-Id:References:References:Autocrypt:Openpgp; i=@matoro.tk; s=20220801; t=1659791521; v=1; x=1660223521; b=YegtRKSQr8okAdxA1AbGAlpGEYfnwiguq7kZDTIIslOWvPut/2nIAOedmBlvW7REWEONU9Wa 4jzxRbKsKALwI+IKYslEpFnwx2N4FHzfyEszO3GM7H5rF+bdEz895lZ7VcziIdGyFhRAmwUKDAP iSQHTTBW4c0yU7Lcr+Ethr89BAryagv5lb5sGbqPqXQQzheKUKZqtHVGp+fXjId/2mjHAJ2GbuA U+sjU8auY+GuL9dOCG8r3gyVykYYPYYMbtV8TzGamNsQnb0gAjS4RvxAyeQyHrpLQ6vJ2H1YDV5 j9uAgdKAmXkwlNX77atViCljK9JqmHGfnRYqa3xRN+2TiKj3jwsC4Rtw/1GLD7d0GcJLhAO4w4y 6hJ75Xxn+h7YeulZEMYDgpZD7krL+zVv+yDDaIp5SE5G7WuuJ1YkJnNrBFgR7rdGcUjNjT7TjGt POTVflo6etSRCsq9znc86mHDwxE7zJemIC7U097DzzSj+ZSgTsRkSe4pQFIWQaq7xC9LcTcjupZ qrnLvre7YX2QjeeKnV80gnZqGoNagrseyxMsYdB+VEvod0Hfo7QqGaqwl9yGuaLCNRKVrF7xWRv 1GThAViZZpCPniUwXYRQPIdPEaQX6p97JDQSqtmTDlevsqlYqFPN8VskQ4Nf9e4275Dj5ZkoVax pYHoZr0Jmv8= Received: by matoro.tk (envelope-sender ) with ESMTPS id 12a86f0d; Sat, 06 Aug 2022 09:12:01 -0400 MIME-Version: 1.0 Date: Sat, 06 Aug 2022 09:12:01 -0400 From: matoro To: sedat.dilek@gmail.com Cc: Masahiro Yamada , Linux Kbuild mailing list , Linux Kernel Mailing List , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Peter Zijlstra , linux-modules , clang-built-linux , Ard Biesheuvel , Sami Tolvanen Subject: Re: [PATCH v6 00/10] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) In-Reply-To: References: <20220513113930.10488-1-masahiroy@kernel.org> <2c496d24174e63b27ec047f383df6700@matoro.tk> Message-ID: X-Sender: matoro_mailinglist_kernel@matoro.tk Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: Hi Sedat - I pulled these configs from the running systems, but I used "make olddefconfig" on these working 5.18 configs to generate the corresponding 5.19 configs that failed to boot. I'll see if I can go back in and repeat this process to regen the 5.19 configs (I deleted it all after 5.19 failed to boot). -------- Original Message -------- Subject: Re: [PATCH v6 00/10] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) Date: 2022-08-06 03:23 From: Sedat Dilek To: matoro On Sat, Aug 6, 2022 at 1:40 AM matoro wrote: > > Hi Masahiro, I'm sorry to raise this after release but this seems to be > broken on SOME architectures. So far I have tested: > > Affected - sparc, alpha > Unaffected - riscv, ia64 > What do you mean by "release"? Checking the kernel-version from your paste-URLs: # Automatically generated file; DO NOT EDIT. # Linux/sparc64 5.18.16-gentoo Kernel Configuration # Automatically generated file; DO NOT EDIT. # Linux/alpha 5.18.15-gentoo Kernel Configuration # Automatically generated file; DO NOT EDIT. # Linux/riscv 5.19.0-gentoo Kernel Configuration # Automatically generated file; DO NOT EDIT. # Linux/ia64 5.19.0-gentoo Kernel Configuration Maybe you should try "Affected - sparc, alpha" with Linux v5.19.0 instead of 5.18.x :-)? -Sedat- > The affected systems are unable to load modules, similar to the > previously reported issue. All module loading fails with "disagrees > about version of symbol module_layout". > > Bisect blames 7b4537199a4a8480b8c3ba37a2d44765ce76cd9b, but this does > not revert cleanly. Presumably CONFIG_MODVERSIONS=n would fix, but > this > is a pretty core feature. > > Unlike the issue Sedat reported, this is on a GNU toolchain, no clang > involved. > > Here are the configs I am using (with make olddefconfig on upgrade to > 5.19): > > Broken - sparc - https://dpaste.com/5A8F2JD6U > Broken - alpha - https://dpaste.com/FYKK23L9X > Working - riscv - https://dpaste.com/HV6Y4V6NT > Working - ia64 - https://dpaste.com/HDLDNEAK4 > > Please let me know if there's anything I can do to help track down this > regression. > > > -------- Original Message -------- > Subject: Re: [PATCH v6 00/10] kbuild: yet another series of cleanups > (modpost, LTO, MODULE_REL_CRCS, export.h) > Date: 2022-05-13 08:20 > From: Masahiro Yamada > To: Linux Kbuild mailing list > > On Fri, May 13, 2022 at 8:42 PM Masahiro Yamada > wrote: > > > > > > This is the third batch of cleanups in this development cycle. > > > > > This series is available at > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > lto-cleanup-v6 > > > > > > Changes in v6: > > - Fix false-positive warnings when CONFIG_TRIM_UNUSED_KSYMS=y > > > > Changes in v5: > > - Fix the build error when CONFIG_DEBUG_INFO_BTF=y (reported by > > Nathan) > > - Clean up arch/m68k/include/asm/export.h (Nick) > > - Keep gen_symversions (and will be removed by a later patch) > > - Add more comments in the script > > > > Changes in v4: > > - Rename .vmlinux-symver.c to .vmlinux.export.c > > because I notice this approach is useful for further cleanups, > > not only for modversioning but also for overall EXPORT_SYMBOL. > > - New patch > > - New. > > Resent of my previous submission. > > > > https://lore.kernel.org/all/20210831074004.3195284-10-masahiroy@kernel.org/ > > - New > > Resent of my previous submission > > > > https://lore.kernel.org/linux-kbuild/20210831074004.3195284-11-masahiroy@kernel.org/ > > > > Changes in v3: > > - New patch > > > > Changes in v2: > > - Simplify the implementation (parse .cmd files after ELF) > > - New patch > > - replace the chain of $(if ...) with $(and ) > > - New patch > > - New patch > > > > Masahiro Yamada (10): > > modpost: extract symbol versions from *.cmd files > > kbuild: link symbol CRCs at final link, removing > > CONFIG_MODULE_REL_CRCS > > kbuild: stop merging *.symversions > > genksyms: adjust the output format to modpost > > kbuild: do not create *.prelink.o for Clang LTO or IBT > > kbuild: check static EXPORT_SYMBOL* by script instead of modpost > > kbuild: make built-in.a rule robust against too long argument error > > kbuild: make *.mod rule robust against too long argument error > > kbuild: add cmd_and_savecmd macro > > kbuild: rebuild multi-object modules when objtool is updated > > > > arch/m68k/include/asm/Kbuild | 1 + > > arch/m68k/include/asm/export.h | 2 - > > arch/powerpc/Kconfig | 1 - > > arch/s390/Kconfig | 1 - > > arch/um/Kconfig | 1 - > > include/asm-generic/export.h | 22 ++- > > include/linux/export-internal.h | 16 +++ > > include/linux/export.h | 30 ++-- > > init/Kconfig | 4 - > > kernel/module.c | 10 +- > > scripts/Kbuild.include | 10 +- > > scripts/Makefile.build | 134 ++++++------------ > > scripts/Makefile.lib | 7 - > > scripts/Makefile.modfinal | 5 +- > > scripts/Makefile.modpost | 9 +- > > scripts/check-local-export | 64 +++++++++ > > scripts/genksyms/genksyms.c | 18 +-- > > scripts/link-vmlinux.sh | 33 ++--- > > scripts/mod/modpost.c | 236 +++++++++++++++++++++----------- > > 19 files changed, 320 insertions(+), 284 deletions(-) > > delete mode 100644 arch/m68k/include/asm/export.h > > create mode 100644 include/linux/export-internal.h > > create mode 100755 scripts/check-local-export > > > > -- > > 2.32.0 > > >