From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: linux-modules <linux-modules@vger.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libkmod-elf: resolve CRC if module is built with MODULE_REL_CRCS
Date: Wed, 19 Jul 2017 22:04:19 +0300 [thread overview]
Message-ID: <xunyh8y8qmdo.fsf@redhat.com> (raw)
In-Reply-To: <CAKi4VA+oMMXajB7_xF2qraye9h7k-JqG5h9Fk7fv9xenW_nvcA@mail.gmail.com> (Lucas De Marchi's message of "Wed, 19 Jul 2017 10:51:44 -0700")
Hi, Lucas!
>>>>> On Wed, 19 Jul 2017 10:51:44 -0700, Lucas De Marchi wrote:
> On Wed, Jul 19, 2017 at 7:56 AM, Yauheni Kaliuta
> <yauheni.kaliuta@redhat.com> wrote:
>> Normally exported symbol's crc is stored as absolute (SHN_ABS)
>> value of special named symbol __crc_<symbol name>.
>>
>> When the kernel and modules are built with the config option
>> CONFIG_MODULE_REL_CRCS, all the CRCs are put in a special section
>> and the __crc_<symbol name> symbols values are offsets in the
>> section. See patch description of the commit:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=56067812d5b0e737ac2063e94a50f76b810d6ca3
>>
>> Add kmod support of this configuration.
[...]
> LGTM. I'll give this a try and apply.
Thanks! I would also like to get some feedback from the kernel feature
author, Ard Biesheuvel, that this does not miss other usecases.
> Do you think it's possible to build an out-of-tree module with this
> option so we can add one to the testsuite?
I'll check what I can do.
The problem is seen if you run depmod with -e -E, which I guess is not used
too often.
--
WBR,
Yauheni Kaliuta
next prev parent reply other threads:[~2017-07-19 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 14:56 [PATCH] libkmod-elf: resolve CRC if module is built with MODULE_REL_CRCS Yauheni Kaliuta
2017-07-19 17:51 ` Lucas De Marchi
2017-07-19 19:04 ` Yauheni Kaliuta [this message]
2017-07-19 19:10 ` Ard Biesheuvel
2017-07-19 19:33 ` Yauheni Kaliuta
2017-08-08 21:40 ` [RFC] resolve CRC test. Was: " Yauheni Kaliuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xunyh8y8qmdo.fsf@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).