linux-modules.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-modules@vger.kernel.org
Subject: Re: [PATCH] testsuite: add simple test for --show-exports
Date: Tue, 13 Nov 2018 21:34:14 +0200	[thread overview]
Message-ID: <xunysh04kc09.fsf@redhat.com> (raw)
In-Reply-To: <20181113184640.3671-1-lucas.demarchi@intel.com> (Lucas De Marchi's message of "Tue, 13 Nov 2018 10:46:40 -0800")

Hi, Lucas!

>>>>> On Tue, 13 Nov 2018 10:46:40 -0800, Lucas De Marchi  wrote:

 > ---
 >  testsuite/populate-modules.sh                 |  1 +
 >  .../test-modprobe/show-exports/correct.txt    |  1 +
 >  testsuite/test-modprobe.c                     | 22 +++++++++++++++++++
 >  3 files changed, 24 insertions(+)
 >  create mode 100644 testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt

 > diff --git a/testsuite/populate-modules.sh b/testsuite/populate-modules.sh
 > index b77e71e..ba68a69 100755
 > --- a/testsuite/populate-modules.sh
 > +++ b/testsuite/populate-modules.sh
 > @@ -39,6 +39,7 @@ map=(
 >      ["test-modprobe/show-depends/lib/modules/4.4.4/kernel/mod-loop-a.ko"]="mod-loop-a.ko"
 >      ["test-modprobe/show-depends/lib/modules/4.4.4/kernel/mod-loop-b.ko"]="mod-loop-b.ko"
 >      ["test-modprobe/show-depends/lib/modules/4.4.4/kernel/mod-simple.ko"]="mod-simple.ko"
 > +    ["test-modprobe/show-exports/mod-loop-a.ko"]="mod-loop-a.ko"
 >      ["test-modprobe/softdep-loop/lib/modules/4.4.4/kernel/mod-loop-a.ko"]="mod-loop-a.ko"
 >      ["test-modprobe/softdep-loop/lib/modules/4.4.4/kernel/mod-loop-b.ko"]="mod-loop-b.ko"
 >      ["test-modprobe/install-cmd-loop/lib/modules/4.4.4/kernel/mod-loop-a.ko"]="mod-loop-a.ko"
 > diff --git a/testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt b/testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt
 > new file mode 100644
 > index 0000000..bc2d045
 > --- /dev/null
 > +++ b/testsuite/rootfs-pristine/test-modprobe/show-exports/correct.txt
 > @@ -0,0 +1 @@
 > +0x00000000	printA

I'm afraid, it won't work if your kernel is built with
MODVERSIONS enabled.

 > diff --git a/testsuite/test-modprobe.c b/testsuite/test-modprobe.c
 > index ee9d82d..52a6621 100644
 > --- a/testsuite/test-modprobe.c
 > +++ b/testsuite/test-modprobe.c
 > @@ -95,6 +95,28 @@ DEFINE_TEST(modprobe_show_alias_to_none,
 >  	);
 
 
 > +static noreturn int modprobe_show_exports(const struct test *t)
 > +{
 > +	const char *progname = ABS_TOP_BUILDDIR "/tools/modprobe";
 > +	const char *const args[] = {
 > +		progname,
 > +		"--show-exports", "--quiet", "/mod-loop-a.ko",
 > +		NULL,
 > +	};
 > +
 > +	test_spawn_prog(progname, args);
 > +	exit(EXIT_FAILURE);
 > +}
 > +DEFINE_TEST(modprobe_show_exports,
 > +	.description = "check if modprobe --show-depends doesn't explode with an alias to nothing",
 > +	.config = {
 > +		[TC_ROOTFS] = TESTSUITE_ROOTFS "test-modprobe/show-exports",
 > +	},
 > +	.output = {
 > +		.out = TESTSUITE_ROOTFS "test-modprobe/show-exports/correct.txt",
 > +	});
 > +
 > +
 >  static noreturn int modprobe_builtin(const struct test *t)
 >  {
 >  	const char *progname = ABS_TOP_BUILDDIR "/tools/modprobe";
 > -- 
 > 2.19.1.1.g56c4683e68


-- 
WBR,
Yauheni Kaliuta

      reply	other threads:[~2018-11-13 19:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 18:46 [PATCH] testsuite: add simple test for --show-exports Lucas De Marchi
2018-11-13 19:34 ` Yauheni Kaliuta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xunysh04kc09.fsf@redhat.com \
    --to=yauheni.kaliuta@redhat.com \
    --cc=linux-modules@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).