From: "Tokunori Ikegami" <ikegami_to@yahoo.co.jp>
To: "'Boris Brezillon'" <boris.brezillon@collabora.com>,
"'liujian \(CE\)'" <liujian56@huawei.com>
Cc: 'Tokunori Ikegami' <ikegami.t@gmail.com>,
keescook@chromium.org, bbrezillon@kernel.org,
ikegami@allied-telesis.co.jp, richard@nod.at,
linux-kernel@vger.kernel.org, marek.vasut@gmail.com,
linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, vigneshr@ti.com
Subject: RE: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
Date: Fri, 1 Mar 2019 23:51:16 +0900 [thread overview]
Message-ID: <005a01d4d03e$39b0e0f0$ad12a2d0$@yahoo.co.jp> (raw)
In-Reply-To: <20190228164228.734ede80@collabora.com>
> -----Original Message-----
> From: linux-mtd [mailto:linux-mtd-bounces@lists.infradead.org] On Behalf
> Of Boris Brezillon
> Sent: Friday, March 1, 2019 12:42 AM
> To: liujian (CE)
> Cc: Tokunori Ikegami; keescook@chromium.org; bbrezillon@kernel.org;
> ikegami@allied-telesis.co.jp; richard@nod.at;
> linux-kernel@vger.kernel.org; marek.vasut@gmail.com;
> linux-mtd@lists.infradead.org; computersforpeace@gmail.com;
> dwmw2@infradead.org; vigneshr@ti.com
> Subject: Re: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c
> do_write_buffer
>
> On Thu, 28 Feb 2019 15:12:15 +0000
> "liujian (CE)" <liujian56@huawei.com> wrote:
>
> > > -----Original Message-----
> > > From: Tokunori Ikegami [mailto:ikegami.t@gmail.com]
> > > Sent: Thursday, February 28, 2019 10:26 PM
> > > To: liujian (CE) <liujian56@huawei.com>; dwmw2@infradead.org;
> > > computersforpeace@gmail.com; bbrezillon@kernel.org;
> > > marek.vasut@gmail.com; richard@nod.at;
> joakim.tjernlund@infinera.com;
> > > ikegami@allied-telesis.co.jp; keescook@chromium.org; vigneshr@ti.com
> > > Cc: linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org
> > > Subject: RE: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c
> do_write_buffer
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: linux-mtd [mailto:linux-mtd-bounces@lists.infradead.org] On
> > > > Behalf Of Liu Jian
> > > > Sent: Tuesday, February 26, 2019 11:01 PM
> > > > To: dwmw2@infradead.org; computersforpeace@gmail.com;
> > > > bbrezillon@kernel.org; marek.vasut@gmail.com; richard@nod.at;
> > > > joakim.tjernlund@infinera.com; ikegami@allied-telesis.co.jp;
> > > > keescook@chromium.org; vigneshr@ti.com
> > > > Cc: linux-mtd@lists.infradead.org; liujian56@huawei.com;
> > > > linux-kernel@vger.kernel.org
> > > > Subject: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c
> > > > do_write_buffer
> > > >
> > > > In function do_write_buffer(), in the for loop, there is a case
> > > > chip_ready() returns 1 while chip_good() returns 0, so it never break
> > > > the loop.
> > > > To fix this, chip_good() is enough and it should timeout if it stay
> > > > bad for a while.
> > > >
> > > > Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to
> > > > check correct value")
> > > > Signed-off-by: Yi Huaijie <yihuaijie@huawei.com>
> > > > Signed-off-by: Liu Jian <liujian56@huawei.com>
> > > > Reviewed-by: Tokunori Ikegami <ikegami_to@yahoo.co.jp>
> > > > ---
> > > > v2->v3:
> > > > Follow Vignesh's advice:
> > > > add one more check for check_good() even when time_after() returns
> true.
> > > >
> > > > drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c
> > > > b/drivers/mtd/chips/cfi_cmdset_0002.c
> > > > index 72428b6..3da2376 100644
> > > > --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> > > > +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> > > > @@ -1876,7 +1876,7 @@ static int __xipram do_write_buffer(struct
> > > > map_info *map, struct flchip *chip,
> > > > continue;
> > > > }
> > > >
> > > > - if (time_after(jiffies, timeo) && !chip_ready(map, adr))
> > > > + if (time_after(jiffies, timeo) && !chip_good(map, adr,
> > > > datum))
> > >
> > > Just another idea to understand easily.
> > >
> > > unsigned long now = jiffies;
> > >
> > > if (chip_good(map, adr, datum)) {
> > > xip_enable(map, chip, adr);
> > > goto op_done;
> > > }
> > >
> > > if (time_after(now, timeo) {
> > > break;
> > > }
> > >
> >
> > Thank you~. It is more easier to understand!
> > If there are no other comments, I will send new patch again ):
>
> Except this version no longer does what Vignesh suggested. See how you
> no longer test if chip_good() is true if time_after() returns true. So,
> imagine the thread entering this function is preempted just after the
> first chip_good() test, and resumed a few ms later. time_after() will
> return true, but chip_good() might also return true, and you ignore it.
I think that the following 3 versions will be worked for time_after() as a same result and follow the Vignesh-san suggestion.
1. Original Vignesh-san suggestion
if (chip_good(map, adr, datum)) {
xip_enable(map, chip, adr);
goto op_done;
}
if (time_after(jiffies, timeo)) {
/* Test chip_good() if TRUE incorrectly again so write failure by time_after() can be avoided. */
if (chip_good(map, adr, datum)) {
xip_enable(map, chip, adr);
goto op_done;
}
break;
}
2. Liujian-san v3 patch
/* Test chip_good() if FALSE correctly so write failure by time_after() can be avoided. */
if (time_after(jiffies, timeo) && !chip_good(map, adr))
break;
if (chip_good(map, adr, datum)) {
xip_enable(map, chip, adr);
goto op_done;
}
3. My idea
/* Save current jiffies value before chip_good() to avoid write failure by time_after() without testing chip_good() again. */
unsigned long now = jiffies;
if (chip_good(map, adr, datum)) {
xip_enable(map, chip, adr);
goto op_done;
}
if (time_after(now, timeo))
break;
Note: Some brackets have been fixed from the previous mail.
Regards,
Ikegami
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-03-01 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:00 [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer Liu Jian
2019-02-28 14:25 ` Tokunori Ikegami
2019-02-28 15:12 ` liujian (CE)
2019-02-28 15:42 ` Boris Brezillon
2019-03-01 14:51 ` Tokunori Ikegami [this message]
2019-03-01 16:07 ` Boris Brezillon
2019-03-01 16:54 ` Tokunori Ikegami
2019-03-01 16:47 ` Vignesh Raghavendra
2019-03-01 16:59 ` Tokunori Ikegami
2019-03-01 17:43 ` Boris Brezillon
2019-03-01 17:55 ` Tokunori Ikegami
2019-03-02 8:57 ` Vignesh Raghavendra
2019-03-01 19:56 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005a01d4d03e$39b0e0f0$ad12a2d0$@yahoo.co.jp' \
--to=ikegami_to@yahoo.co.jp \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ikegami.t@gmail.com \
--cc=ikegami@allied-telesis.co.jp \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=liujian56@huawei.com \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).