From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Boris Brezillon <bbrezillon@kernel.org>,
Jeff Kletsky <git-commits@allycomm.com>,
liaoweixiong <liaoweixiong@allwinnertech.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Peter Pan <peterpandong@micron.com>
Cc: Richard Weinberger <richard@nod.at>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/3] mtd: spinand: Stop using spinand->oobbuf for buffering bad block markers
Date: Tue, 11 Feb 2020 18:35:39 +0000 [thread overview]
Message-ID: <0f4f2b38-3a5c-fff8-6cd8-e24c94504d9d@kontron.de> (raw)
In-Reply-To: <20200211163452.25442-2-frieder.schrempf@kontron.de>
On 11.02.20 17:35, Schrempf Frieder wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> For reading and writing the bad block markers, spinand->oobbuf is
> currently used as a buffer for the marker bytes. During the
> underlying read and write operations to actually get/set the content
> of the OOB area, the content of spinand->oobbuf is reused and changed
> by accessing it through spinand->oobbuf and/or spinand->databuf.
>
> This is a flaw in the original design of the SPI MEM core and at the
This should be SPI NAND, of course. ^
> latest from 13c15e07eedf ("mtd: spinand: Handle the case where
> PROGRAM LOAD does not reset the cache") on, it results in not having
> the bad block marker written at all, as the spinand->oobbuf is
> cleared to 0xff after setting the marker bytes to zero.
>
> To fix it, we now just store the two bytes for the marker on the
> stack and let the read/write operations copy it from/to the page
> buffer later.
>
> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> drivers/mtd/nand/spi/core.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 89f6beefb01c..5d267a67a5f7 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -568,18 +568,18 @@ static int spinand_mtd_write(struct mtd_info *mtd, loff_t to,
> static bool spinand_isbad(struct nand_device *nand, const struct nand_pos *pos)
> {
> struct spinand_device *spinand = nand_to_spinand(nand);
> + u8 marker[] = { 0, 0 };
> struct nand_page_io_req req = {
> .pos = *pos,
> .ooblen = 2,
> .ooboffs = 0,
> - .oobbuf.in = spinand->oobbuf,
> + .oobbuf.in = marker,
> .mode = MTD_OPS_RAW,
> };
>
> - memset(spinand->oobbuf, 0, 2);
> spinand_select_target(spinand, pos->target);
> spinand_read_page(spinand, &req, false);
> - if (spinand->oobbuf[0] != 0xff || spinand->oobbuf[1] != 0xff)
> + if (marker[0] != 0xff || marker[1] != 0xff)
> return true;
>
> return false;
> @@ -603,11 +603,12 @@ static int spinand_mtd_block_isbad(struct mtd_info *mtd, loff_t offs)
> static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos)
> {
> struct spinand_device *spinand = nand_to_spinand(nand);
> + u8 marker[] = { 0, 0 };
> struct nand_page_io_req req = {
> .pos = *pos,
> .ooboffs = 0,
> .ooblen = 2,
> - .oobbuf.out = spinand->oobbuf,
> + .oobbuf.out = marker,
> };
> int ret;
>
> @@ -622,7 +623,6 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos)
>
> spinand_erase_op(spinand, pos);
>
> - memset(spinand->oobbuf, 0, 2);
> return spinand_write_page(spinand, &req);
> }
>
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-02-11 18:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 16:35 [PATCH 0/3] mtd: spinand: Fix reading and writing of bad block markers Schrempf Frieder
2020-02-11 16:35 ` [PATCH 1/3] mtd: spinand: Stop using spinand->oobbuf for buffering " Schrempf Frieder
2020-02-11 18:35 ` Schrempf Frieder [this message]
2020-02-17 11:17 ` Boris Brezillon
2020-02-11 16:35 ` [PATCH 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Schrempf Frieder
2020-02-17 11:18 ` Boris Brezillon
2020-02-11 16:35 ` [PATCH 3/3] mtd: spinand: Wait for the erase op to finish before writing a bad block marker Schrempf Frieder
2020-02-17 10:39 ` Miquel Raynal
2020-02-17 11:14 ` Boris Brezillon
2020-02-17 11:29 ` Schrempf Frieder
2020-02-17 11:19 ` Schrempf Frieder
2020-02-17 11:30 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f4f2b38-3a5c-fff8-6cd8-e24c94504d9d@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=bbrezillon@kernel.org \
--cc=git-commits@allycomm.com \
--cc=liaoweixiong@allwinnertech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=peterpandong@micron.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).