Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mtd: spi-nor: Add Winbond w25q16jv support
@ 2019-02-14 20:57 Robert Marko
  2019-02-20 20:29 ` Tudor.Ambarus
  0 siblings, 1 reply; 4+ messages in thread
From: Robert Marko @ 2019-02-14 20:57 UTC (permalink / raw)
  To: marek.vasut, dwmw2, computersforpeace, bbrezillon, richard,
	linux-mtd, linux-kernel
  Cc: Robert Marko

Datasheet: https://www.winbond.com/resource-files/w25q16jv%20spi%20revg%2003222018%20plus.pdf

Testing done on Mikrotik Routerboard RB450Gx4 board under 4.19.19 kernel.

Test board does not support Dual or Quad modes.

Signed-off-by: Robert Marko <robimarko@gmail.com>
---
 drivers/mtd/spi-nor/spi-nor.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 6e13bbd1aaa5..0e958f48db1b 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -1975,6 +1975,11 @@ static const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		"w25q16jv", INFO(0xef7015, 0, 64 * 1024,  32,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 	{ "w25x32", INFO(0xef3016, 0, 64 * 1024,  64, SECT_4K) },
 	{ "w25q20cl", INFO(0xef4012, 0, 64 * 1024,  4, SECT_4K) },
 	{ "w25q20bw", INFO(0xef5012, 0, 64 * 1024,  4, SECT_4K) },
-- 
2.20.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: spi-nor: Add Winbond w25q16jv support
  2019-02-14 20:57 [PATCH] mtd: spi-nor: Add Winbond w25q16jv support Robert Marko
@ 2019-02-20 20:29 ` Tudor.Ambarus
  2019-02-21 20:58   ` Robert Marko
  0 siblings, 1 reply; 4+ messages in thread
From: Tudor.Ambarus @ 2019-02-20 20:29 UTC (permalink / raw)
  To: robimarko, marek.vasut, dwmw2, computersforpeace, bbrezillon,
	richard, linux-mtd, linux-kernel, bbrezillon

Hi, Robert,

On 02/14/2019 10:57 PM, Robert Marko wrote:
> Datasheet: https://www.winbond.com/resource-files/w25q16jv%20spi%20revg%2003222018%20plus.pdf
> 
> Testing done on Mikrotik Routerboard RB450Gx4 board under 4.19.19 kernel.

It is preferable to do the test on spi-nor/next
> 
> Test board does not support Dual or Quad modes.
> 
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 6e13bbd1aaa5..0e958f48db1b 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1975,6 +1975,11 @@ static const struct flash_info spi_nor_ids[] = {
>  			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>  			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>  	},
> +	{
> +		"w25q16jv", INFO(0xef7015, 0, 64 * 1024,  32,
> +			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)

You'll need a way to differentiate between W25Q16JV-IQ/JQ and W25Q16JV-IM/JM.

And I would prefer to have the new entries ordered alphabetically as much as
possible. This one should fit just before w25q20cl. Manufacturers are naming
flashes based on a product identification system. The flashes are presented in
alphabetical order, we should do the same.

Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: spi-nor: Add Winbond w25q16jv support
  2019-02-20 20:29 ` Tudor.Ambarus
@ 2019-02-21 20:58   ` Robert Marko
  2019-06-13 14:33     ` Tudor.Ambarus
  0 siblings, 1 reply; 4+ messages in thread
From: Robert Marko @ 2019-02-21 20:58 UTC (permalink / raw)
  To: Tudor.Ambarus
  Cc: bbrezillon, richard, linux-kernel, Marek Vašut, linux-mtd,
	Brian Norris, David Woodhouse

On Wed, 20 Feb 2019 at 21:29, <Tudor.Ambarus@microchip.com> wrote:>>
Hi, Robert,>> On 02/14/2019 10:57 PM, Robert Marko wrote:> >
Datasheet: https://www.winbond.com/resource-files/w25q16jv%20spi%20revg%2003222018%20plus.pdf>
>> > Testing done on Mikrotik Routerboard RB450Gx4 board under 4.19.19
kernel.>> It is preferable to do the test on spi-nor/nextUnfortunately
I cant do that as OpenWrt has a considerable amount of patches that
would need to be ported and we are only moving from LTS to LTS version
and we are currently on 4.19.
> >
> > Test board does not support Dual or Quad modes.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 6e13bbd1aaa5..0e958f48db1b 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -1975,6 +1975,11 @@ static const struct flash_info spi_nor_ids[] = {
> >                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> >                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> >       },
> > +     {
> > +             "w25q16jv", INFO(0xef7015, 0, 64 * 1024,  32,
> > +                     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                     SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>
> You'll need a way to differentiate between W25Q16JV-IQ/JQ and W25Q16JV-IM/JM.
Hm, from what I understood JV is the series and suffix only indictes
the package.
They should all have the same JEDEC ID and features.
>
> And I would prefer to have the new entries ordered alphabetically as much as
> possible. This one should fit just before w25q20cl. Manufacturers are naming
> flashes based on a product identification system. The flashes are presented in
> alphabetical order, we should do the same.
I agree, will reorder and send a v2.
>
> Cheers,
> ta

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: spi-nor: Add Winbond w25q16jv support
  2019-02-21 20:58   ` Robert Marko
@ 2019-06-13 14:33     ` Tudor.Ambarus
  0 siblings, 0 replies; 4+ messages in thread
From: Tudor.Ambarus @ 2019-06-13 14:33 UTC (permalink / raw)
  To: robimarko
  Cc: vigneshr, bbrezillon, richard, linux-kernel, marek.vasut,
	linux-mtd, computersforpeace, dwmw2

Hi, Robert,

On 02/21/2019 10:58 PM, Robert Marko wrote:
> On Wed, 20 Feb 2019 at 21:29, <Tudor.Ambarus@microchip.com> wrote:>>
> Hi, Robert,>> On 02/14/2019 10:57 PM, Robert Marko wrote:> >
> Datasheet: https://www.winbond.com/resource-files/w25q16jv%20spi%20revg%2003222018%20plus.pdf>
>>>> Testing done on Mikrotik Routerboard RB450Gx4 board under 4.19.19
> kernel.>> It is preferable to do the test on spi-nor/nextUnfortunately
> I cant do that as OpenWrt has a considerable amount of patches that
> would need to be ported and we are only moving from LTS to LTS version
> and we are currently on 4.19.
>>>
>>> Test board does not support Dual or Quad modes.
>>>
>>> Signed-off-by: Robert Marko <robimarko@gmail.com>
>>> ---
>>>  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>>> index 6e13bbd1aaa5..0e958f48db1b 100644
>>> --- a/drivers/mtd/spi-nor/spi-nor.c
>>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>>> @@ -1975,6 +1975,11 @@ static const struct flash_info spi_nor_ids[] = {
>>>                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>>>                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>>       },
>>> +     {
>>> +             "w25q16jv", INFO(0xef7015, 0, 64 * 1024,  32,
>>> +                     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>>> +                     SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>
>> You'll need a way to differentiate between W25Q16JV-IQ/JQ and W25Q16JV-IM/JM.
> Hm, from what I understood JV is the series and suffix only indictes
> the package.
> They should all have the same JEDEC ID and features.
>>

W25Q16JV-IQ/JQ and W25Q16JV-IM/JM have different jedec ids, see table "9.1.1
Manufacturer and Device Identification" from the datasheet that you indicated in
the commit message.

Looking at "12. ORDERING INFORMATION", I see that:
- Q version has QE = 1 (fixed) and it's backward compatible to FV family
- M version has QE = 0 (programmable) and has a new device ID
The same is described in "8. QUAD ENABLE (QE) – Volatile/Non-Volatile Writable".

I would suggest to name the flash "w25q16jv-im/jm".

What do you think?
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 20:57 [PATCH] mtd: spi-nor: Add Winbond w25q16jv support Robert Marko
2019-02-20 20:29 ` Tudor.Ambarus
2019-02-21 20:58   ` Robert Marko
2019-06-13 14:33     ` Tudor.Ambarus

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org linux-mtd@archiver.kernel.org
	public-inbox-index linux-mtd


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/ public-inbox