Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <miquel.raynal@bootlin.com>
Cc: richard@nod.at, linux-mtd@lists.infradead.org, vigneshr@ti.com
Subject: Re: [PATCH v2] mtd: Convert fallthrough comments into statements
Date: Fri, 27 Mar 2020 08:43:52 +0000
Message-ID: <11409771.dsHhkDzkrP@192.168.0.120> (raw)
In-Reply-To: <20200325212115.14170-1-miquel.raynal@bootlin.com>

On Wednesday, March 25, 2020 11:21:15 PM EET Miquel Raynal wrote:
> --- a/drivers/mtd/spi-nor/sfdp.c
> +++ b/drivers/mtd/spi-nor/sfdp.c
> @@ -623,7 +623,6 @@ static u8 spi_nor_smpt_addr_width(const struct spi_nor
> *nor, const u32 settings) case SMPT_CMD_ADDRESS_LEN_4:
>                 return 4;
>         case SMPT_CMD_ADDRESS_LEN_USE_CURRENT:
> -               /* fall through */

just noticed that you forgot the statement here.

>         default:
>                 return nor->addr_width;
>         }




______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 21:21 Miquel Raynal
2020-03-27  8:43 ` Tudor.Ambarus [this message]
2020-03-27  8:53   ` Miquel Raynal
2020-03-27 10:47     ` Tudor.Ambarus
2020-03-28 19:33 ` Richard Weinberger
2020-03-30  8:15 ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11409771.dsHhkDzkrP@192.168.0.120 \
    --to=tudor.ambarus@microchip.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git