From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qc0-f202.google.com ([209.85.216.202]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WSb69-0006iK-A9 for linux-mtd@lists.infradead.org; Tue, 25 Mar 2014 23:49:39 +0000 Received: by mail-qc0-f202.google.com with SMTP id m20so169691qcx.5 for ; Tue, 25 Mar 2014 16:49:13 -0700 (PDT) From: Gwendal Grignou To: axboe@kernel.dk, ulf.hansson@linaro.org Subject: [PATCH 4/4] Limit max_discard_sectors to UINT_MAX>>9 Date: Tue, 25 Mar 2014 16:48:26 -0700 Message-Id: <1395791307-23727-5-git-send-email-gwendal@chromium.org> In-Reply-To: <1395791307-23727-1-git-send-email-gwendal@chromium.org> References: <1395791307-23727-1-git-send-email-gwendal@chromium.org> Cc: linux-mmc@vger.kernel.org, Gwendal Grignou , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , max_discard_sectors can not be larger than UINT_MAX>>9, otherwise, there is a risk that discard requests would be merged into a request larger than 4GB. Signed-off-by: Gwendal Grignou --- drivers/mtd/mtd_blkdevs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index 5073cbc..e74090c 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -416,7 +416,7 @@ int add_mtd_blktrans_dev(struct mtd_blktrans_dev *new) if (tr->discard) { queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, new->rq); - new->rq->limits.max_discard_sectors = UINT_MAX; + new->rq->limits.max_discard_sectors = UINT_MAX >> 9; } gd->queue = new->rq; -- 1.9.1.423.g4596e3a