From: Richard Weinberger <richard@nod.at>
To: chengzhihao1 <chengzhihao1@huawei.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
yi zhang <yi.zhang@huawei.com>
Subject: Re: 答复: [PATCH RFC] ubi: ubi_wl_get_peb: Replace a limited number of attempts with polling while getting PEB
Date: Thu, 1 Aug 2019 11:20:54 +0200 (CEST) [thread overview]
Message-ID: <1515821930.55881.1564651254907.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <0B80F9D4116B2F4484E7279D5A66984F7A8A13@dggemi524-mbx.china.huawei.com>
----- Ursprüngliche Mail -----
> Von: "chengzhihao1" <chengzhihao1@huawei.com>
> An: "richard" <richard@nod.at>, "yi zhang" <yi.zhang@huawei.com>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Donnerstag, 1. August 2019 11:13:20
> Betreff: 答复: [PATCH RFC] ubi: ubi_wl_get_peb: Replace a limited number of attempts with polling while getting PEB
> I don't quite understand why a limited number of attempts have been made to get
> a free PEB in ubi_wl_get_peb (in fastmap-wl.c). I proposed this PATCH with
> reference to the implementation of ubi_wl_get_peb (in wl.c). As far as I know,
> getting PEB by polling probably won't fall into soft-lockup.
> ubi_update_fastmap may add new tasks (including erase task or wl taskk, wl tasks
> generally do not generate additional free PEBs) to ubi->works, and
> produce_free_peb will eventually complete all tasks in ubi->works or obtain an
> free PEB that can be filled into pool.
You send this patch three times, I guess your mail setup has issues? :-)
This is one of the darkest corners of Fastmap where things get messy.
The number of retry attempts was limited to avoid a live lock.
I agree that allowing only one retry is a little to few.
With nandsim, a small nand and a fast PC you can hit that.
Do you have numbers how many attempts were needed to get a free block?
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-08-01 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 9:17 [PATCH RFC] ubi: ubi_wl_get_peb: Replace a limited number of attempts with polling while getting PEB Zhihao Cheng
2019-08-01 9:13 ` 答复: " chengzhihao
2019-08-01 9:20 ` Richard Weinberger [this message]
2019-08-01 9:26 ` 答复: " chengzhihao
2019-08-01 9:40 ` Richard Weinberger
2019-08-01 13:19 ` 答复: " chengzhihao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515821930.55881.1564651254907.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=chengzhihao1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).