From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F104AC169C4 for ; Fri, 8 Feb 2019 08:10:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A14352147C for ; Fri, 8 Feb 2019 08:10:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nqkprOjJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="E/cAtWmy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A14352147C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=e0uVoFIFE7fjivFr4ylsvJopTbLmYjPMueGf+deXLh0=; b=nqkprOjJwiMaC9pfRu/EZmkHsJ Al7IPmhwmtst0jzF0OWskNiEBitYRxo2dKxrxr2UrShzTpXrKpQAdPhq7a7S5k8bRlZ41/3Ghgb7E qVYHFKFw2IfRl+ecTDr23zxzvFEbLijBEdB3kpBL0hxFav6Z9JzQgzCNCltJkLTCmNw666GPFYg+q BmFldzlFhWbJt5C6D6r1QwXeGgihLIp6/OgVnQF6IB7SidjsQ3HaZpZdzEvimPvGNSzsLyPNGfsaO OjC7RZD0xNaRrlnU2dRncwCQcgFV93FbYHOJ4mfbvQRdDqneMw/S91Boaxsh4i8eYr+kgZGTDfPSM 1d/P8E+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gs1EV-00072e-Sx; Fri, 08 Feb 2019 08:09:59 +0000 Received: from conuserg-07.nifty.com ([210.131.2.74]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gs1Dt-0006P1-Tt for linux-mtd@lists.infradead.org; Fri, 08 Feb 2019 08:09:26 +0000 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x188902F007241; Fri, 8 Feb 2019 17:09:06 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x188902F007241 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1549613347; bh=ys+VaiSONmRbjGmiyqILt6uJVydiMxaORBDyTleTud4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E/cAtWmyNYyatM9voK3t9AsjiBBkW2sJIrKE0DmQZMOw3XIZdY6aksGi0ac6dMhh+ LSFyPnvjOPrsUe6iFkoODNvE3QIT5kIbxiaf+XqQTj2dSyENKXhgIUPO3K/NfNFi/W xLW1BHWGxozOevaQ1bFZgb9hzE4sc4khTqw8FgEDRkF3a+IlEov4wXgi/rzYHqxLeo op6oIjBkIao9OACBDZH9uozyGwisFAKt9wKMpR+fOEX+wAZ4FlOxIH2ckVdu1z72D4 ueJ04aXyZFHF0GptruHjdgQuDyqWhnlx01zOqXRTfLusN5KmiffnPAZ0fAQAsTx1WG Z+2wEdUOQf76A== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Subject: [PATCH 06/11] mtd: rawnand: denali: use more precise timeout for NAND_OP_WAITRDT_INSTR Date: Fri, 8 Feb 2019 17:08:50 +0900 Message-Id: <1549613335-30319-7-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549613335-30319-1-git-send-email-yamada.masahiro@socionext.com> References: <1549613335-30319-1-git-send-email-yamada.masahiro@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190208_000922_399943_1E9A251C X-CRM114-Status: GOOD ( 12.42 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Masahiro Yamada , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, Marek Vasut , Brian Norris , David Woodhouse MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Currently, wait_for_completion_timeout() is always passed in the hard-coded msec_to_jiffies(1000). There is no specific reason for 1000 msec, but I just chose it long enough. With the exec_op() conversion, NAND_OP_WAITRDY_INSTR provides more precise timeout value, depending on the preceding command. Let's use it to bail out earlier in error case. I am still keeping the hard-coded values for other higher level hooks such as page_read, page_write, etc. We know the value of tR, tPROG, but we have unknowledge about the data transfer speed of the DMA engine. Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/raw/denali.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index 9e63cbd..514d189 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -176,7 +176,7 @@ static void denali_reset_irq(struct denali_nand_info *denali) } static uint32_t denali_wait_for_irq(struct denali_nand_info *denali, - uint32_t irq_mask) + u32 irq_mask, unsigned int timeout_ms) { unsigned long time_left, flags; u32 irq_stat; @@ -196,7 +196,7 @@ static uint32_t denali_wait_for_irq(struct denali_nand_info *denali, spin_unlock_irqrestore(&denali->irq_lock, flags); time_left = wait_for_completion_timeout(&denali->complete, - msecs_to_jiffies(1000)); + msecs_to_jiffies(timeout_ms)); if (!time_left) { dev_err(denali->dev, "timeout while waiting for irq 0x%x\n", irq_mask); @@ -349,7 +349,7 @@ static int denali_sw_ecc_fixup(struct nand_chip *chip, * Once handle all ECC errors, controller will trigger an * ECC_TRANSACTION_DONE interrupt. */ - irq_stat = denali_wait_for_irq(denali, INTR__ECC_TRANSACTION_DONE); + irq_stat = denali_wait_for_irq(denali, INTR__ECC_TRANSACTION_DONE, 10); if (!(irq_stat & INTR__ECC_TRANSACTION_DONE)) return -EIO; @@ -421,7 +421,7 @@ static int denali_pio_read(struct denali_nand_info *denali, u32 *buf, for (i = 0; i < size / 4; i++) buf[i] = denali->host_read(denali, addr); - irq_stat = denali_wait_for_irq(denali, INTR__PAGE_XFER_INC); + irq_stat = denali_wait_for_irq(denali, INTR__PAGE_XFER_INC, 10); if (!(irq_stat & INTR__PAGE_XFER_INC)) return -EIO; @@ -444,7 +444,8 @@ static int denali_pio_write(struct denali_nand_info *denali, const u32 *buf, denali->host_write(denali, addr, buf[i]); irq_stat = denali_wait_for_irq(denali, - INTR__PROGRAM_COMP | INTR__PROGRAM_FAIL); + INTR__PROGRAM_COMP | INTR__PROGRAM_FAIL, + 1000); if (!(irq_stat & INTR__PROGRAM_COMP)) return -EIO; @@ -501,7 +502,7 @@ static int denali_dma_xfer(struct denali_nand_info *denali, void *buf, denali_reset_irq(denali); denali->setup_dma(denali, dma_addr, page, write); - irq_stat = denali_wait_for_irq(denali, irq_mask); + irq_stat = denali_wait_for_irq(denali, irq_mask, 1000); if (!(irq_stat & INTR__DMA_CMD_COMP)) ret = -EIO; else if (irq_stat & ecc_err_mask) @@ -1168,12 +1169,13 @@ static void denali_exec_out16(struct denali_nand_info *denali, u32 type, buf[i + 1] << 16 | buf[i]); } -static int denali_exec_waitrdy(struct denali_nand_info *denali) +static int denali_exec_waitrdy(struct denali_nand_info *denali, + unsigned int timeout_ms) { u32 irq_stat; /* R/B# pin transitioned from low to high? */ - irq_stat = denali_wait_for_irq(denali, INTR__INT_ACT); + irq_stat = denali_wait_for_irq(denali, INTR__INT_ACT, timeout_ms); /* Just in case nand_operation has multiple NAND_OP_WAITRDY_INSTR. */ denali_reset_irq(denali); @@ -1212,7 +1214,8 @@ static int denali_exec_instr(struct nand_chip *chip, instr->ctx.data.len); return 0; case NAND_OP_WAITRDY_INSTR: - return denali_exec_waitrdy(denali); + return denali_exec_waitrdy(denali, + instr->ctx.waitrdy.timeout_ms); default: WARN_ONCE(1, "unsupported NAND instruction type: %d\n", instr->type); -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/