From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 362ABC43381 for ; Wed, 13 Mar 2019 13:00:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06424214AE for ; Wed, 13 Mar 2019 13:00:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WrGydWBg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="ldehnXed" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06424214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l/LCN7cuHkOQAp/mWbpf/D2r5Xt6Y89sYM1mHS5LKgA=; b=WrGydWBgFqrBN2kbkl2m3QBRv ypBPlN9D4fVwVAq+uMM/ZJSQY/Pd9KihkILephJbddCTkxORBKitxdKtF6e24k9UIcWxrYxeKlQKl CjSemKgMyt0CZUSBJxz3EzqpeWSxOjfiJhXeCkzWaoVp8OkCMrvxooauOZdeuSjjD/kw2psb+FH9m YV8L3/wOrX4cukmDM+2hoL/6i35YcOg1NumPz0CJzyR9tnPtrQciXjhShZXQ8zMidiW3eUK6YWgem Ym2sqzq2AUCSPZWUA1DlcUSJPz70V2XUEplnL2xXnK5HcpGaQ+Jel2UwOTMi38eAi3xg19QeJoeBk CAVuWQvOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h43UH-0007CE-Q0; Wed, 13 Mar 2019 13:00:01 +0000 Received: from outils.crapouillou.net ([89.234.176.41] helo=crapouillou.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h43UC-0007Bn-Gc for linux-mtd@lists.infradead.org; Wed, 13 Mar 2019 12:59:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1552481993; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CQfhMEahN/XrocGBGIFWacACkKiBhn1UP0sVp4+5o4E=; b=ldehnXedF7XsNQEdYt+WNCD79TY93OlbKMUJxZq0I6kYpNvO31/WlkBPmRn+Tzo2Ub4qie +bwnqvZib1oimQr89EzzXngJ2o/Mgo+Ep31PTI9Q3cqyOXT4/Q2V1zouIwL5jBtMFUXpoh pIEPyyG3vR7MMBBAcESULnsRND56Zug= Date: Wed, 13 Mar 2019 09:59:48 -0300 From: Paul Cercueil Subject: Re: [PATCH v4 2/9] dt-bindings: mtd: ingenic: Change 'BCH' to 'ECC' in documentation To: Miquel Raynal Message-Id: <1552481988.2412.2@crapouillou.net> In-Reply-To: <20190304195852.45c056f6@xps13> References: <20190209192305.4434-1-paul@crapouillou.net> <20190209192305.4434-2-paul@crapouillou.net> <20190304105014.0cceea0a@xps13> <1551723830.4932.3@crapouillou.net> <20190304195852.45c056f6@xps13> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_055956_946412_1396E864 X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Boris Brezillon , Richard Weinberger , linux-kernel@vger.kernel.org, Marek Vasut , Rob Herring , linux-mtd@lists.infradead.org, Harvey Hunt , Brian Norris , David Woodhouse Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Le lun. 4 mars 2019 =E0 15:58, Miquel Raynal = a =E9crit : > Hi Paul, > = > Paul Cercueil wrote on Mon, 04 Mar 2019 = > 19:23:50 > +0100: > = >> On Mon, Mar 4, 2019 at 10:50 AM, Miquel Raynal = >> wrote: >> > Hi Paul, >> > >> > Paul Cercueil > > > wrote on Sat, 9 Feb 2019 16:22:58 >> > -0300: >> > >> >> The JZ4740 ECC hardware is not BCH but Reed-Solomon, so it = >> makes >> more >> >> sense to use the more generic ECC term. >> >> >> Signed-off-by: Paul Cercueil > = >> > >> >> --- >> >> >> Changes: >> >> >> v3: New patch >> >> >> v4: No change >> >> >> .../devicetree/bindings/mtd/ingenic,jz4780-nand.txt | 18 = >> >> +++++++++--------- >> >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> >> diff --git >> = >> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> = >> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> >> index a5b940f18bf6..5a45cc54f46d 100644 >> >> --- = >> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> >> +++ = >> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> >> @@ -1,4 +1,4 @@ >> >> -* Ingenic JZ4780 NAND/BCH >> >> +* Ingenic JZ4780 NAND/ECC >> >> >> This file documents the device tree bindings for NAND flash = >> >> devices on the >> >> JZ4780. NAND devices are connected to the NEMC controller >> = >> (described in >> >> @@ -14,10 +14,10 @@ Required NAND controller device properties: >> >> an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC = >> >> bank). >> >> >> Optional NAND controller device properties: >> >> -- ingenic,bch-controller: To make use of the hardware BCH >> = >> controller, this >> >> - property must contain a phandle for the BCH controller node. = >> The >> required >> >> +- ingenic,bch-controller: To make use of the hardware ECC >> = >> controller, this >> >> + property must contain a phandle for the ECC controller node. = >> The >> required >> > >> > I think there is already a 'ecc-engine' property used by MTK and = >> Atmel >> > NAND controllers to point to the ECC engine block. Please use this >> > property instead of the ingenic specific one. >> = >> ingenic,bch-controller is already in the devicetree ABI. I can't = >> change it now... > = > Oh, right... > = > Well, same thing as before, maybe you can change it and keep the = > driver > backward compatible? I don't want new DT to use this property because > it is not generic and we must have a way from the core to find the ECC > engine handle when the controller does not embed one itself (thus, the > ecc-engine property which is around for quite some time already). I can do that. Will the new ECC framework work with the "ecc-engine" = property? -Paul ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/