Re: [PATCH 09/10] mtd: rawnand: gpmi: use runtime PM to manage clocks

From: Lucas Stach <l.stach@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>, linux-mtd@lists.infradead.org
Cc: Sam Lefebvre <sam.lefebvre@essensium.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	kernel@pengutronix.de, Miquel Raynal <miquel.raynal@bootlin.com>,
	Han Xu <han.xu@nxp.com>
Subject: Re: [PATCH 09/10] mtd: rawnand: gpmi: use runtime PM to manage clocks
Date: Fri, 05 Apr 2019 12:23:15 +0200	[thread overview]
Message-ID: <1554459795.2748.12.camel@pengutronix.de> (raw)
In-Reply-To: <20190405100740.5074-10-s.hauer@pengutronix.de>

Am Freitag, den 05.04.2019, 12:07 +0200 schrieb Sascha Hauer:
> The gpmi driver aggressively en/disables the clocks between operations
> which has significant performance cost. Use runtime PM to get rid of
> this bottleneck.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
[...]
> +static int __maybe_unused gpmi_runtime_suspend(struct device *dev)
> +{
> +	struct gpmi_nand_data *this = dev_get_drvdata(dev);
> +
> +	printk("%s\n", __func__);
> +
> +	return __gpmi_enable_clk(this, false);
> +}
> +
> +static int __maybe_unused gpmi_runtime_resume(struct device *dev)
> +{
> +	struct gpmi_nand_data *this = dev_get_drvdata(dev);
> +
> +	printk("%s\n", __func__);

Leftover debugging in both functions.

Regards,
Lucas

> +
> +	return __gpmi_enable_clk(this, true);
> +}
> +
>  static const struct dev_pm_ops gpmi_pm_ops = {
>  	SET_SYSTEM_SLEEP_PM_OPS(gpmi_pm_suspend, gpmi_pm_resume)
> +	SET_RUNTIME_PM_OPS(gpmi_runtime_suspend, gpmi_runtime_resume, NULL)
>  };
>  
>  static struct platform_driver gpmi_nand_driver = {

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/