From: Xiaoming Ni <nixiaoming@huawei.com>
To: <joern@lazybastard.org>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <marek.vasut@gmail.com>,
<miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>
Cc: nixiaoming@huawei.com, dylix.dailei@huawei.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
zhoubo.zhao@huawei.com
Subject: [PATCH] mtd: phram: Module parameters add writable permissions
Date: Sun, 14 Jul 2019 11:57:18 +0800 [thread overview]
Message-ID: <1563076638-101332-1-git-send-email-nixiaoming@huawei.com> (raw)
The phram code implements managing multiple devices through a linked
list.
However, due to the module parameter permission of 0, the
/sys/module/phram/parameters/phram interface is missing.
The command line arguments in insmod can only create one device.
Therefore, add writable permissions to the module parameters, create
/sys/module/phram/parameters/phram interface, and create multi-device
support.
Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
---
drivers/mtd/devices/phram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index c467286..931e5c2 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -294,7 +294,7 @@ static int phram_param_call(const char *val, const struct kernel_param *kp)
#endif
}
-module_param_call(phram, phram_param_call, NULL, NULL, 000);
+module_param_call(phram, phram_param_call, NULL, NULL, 0200);
MODULE_PARM_DESC(phram, "Memory region to map. \"phram=<name>,<start>,<length>\"");
--
1.8.5.6
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
reply other threads:[~2019-07-14 3:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563076638-101332-1-git-send-email-nixiaoming@huawei.com \
--to=nixiaoming@huawei.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=dylix.dailei@huawei.com \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zhoubo.zhao@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).