From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA64FC76190 for ; Fri, 26 Jul 2019 00:10:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F6FC22CBA for ; Fri, 26 Jul 2019 00:10:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aOOvs2qX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="EjeAwp0Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F6FC22CBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:To: Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lQH4yg10PBmoxqdrbRXsL9kKAkR+qgn3Sp5TESSkm5Y=; b=aOOvs2qXzlSLYywZ/LGEtrPZp t/w/qKSxvmf5qFfxxcJ0z/PKBxvXwJEKKb85U7xuqJJOP4JfoKiaUNoYgS/Vzu+NZHfeUYGNlIHqE dHnhSuJGsdRoWF87At3ublUCcFietzt5c3UMh0Kw8wylE5rjhV+kutr8q02zdtm0TgE0dzgRrpp6k hCT2gruEpwJHetjKm3y5g7UeRrI5ahmDJkIkKZAoqs1tsR4K0UWEV7PnKZSI6tAlIFinywklkmitn 65NXJiVq5klZ9ExrEJ6xqxjGsoYJOSk999HMTmdoxvJM50DLFyCnabZoGuOUh6hmfG3NulFIXChRL oCnGTQABQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqnoQ-0003M9-9s; Fri, 26 Jul 2019 00:10:18 +0000 Received: from outils.crapouillou.net ([89.234.176.41] helo=crapouillou.net) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqnoM-0003LD-Ub for linux-mtd@lists.infradead.org; Fri, 26 Jul 2019 00:10:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1564099806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gFaFrhEeyihyNbT3NtUBxEN4a+tGXeK6Vj+6otZDbtA=; b=EjeAwp0Z/Iz3JRj9xNi/OYWvP2qoXOXLR2kbAZQ7FDIMPuZOSiF0qc+SgEr+9qWUDz7njx 9fSJSmwLBKrpzZNSM2vLDDU9dSKZqz4/qtlXGm6qm9sWN7tSWyprI05k88rU07mM/u+DSu bZeGz0/dkH6Ou3QGiuwrGDsK3pWy2rI= Date: Thu, 25 Jul 2019 20:09:41 -0400 From: Paul Cercueil Subject: Re: [PATCH 02/11] MIPS: qi_lb60: Migrate to devicetree To: Paul Burton Message-Id: <1564099781.1699.0@crapouillou.net> In-Reply-To: <20190725234735.h7qmtt26qpkjw3n6@pburton-laptop> References: <20190725220215.460-1-paul@crapouillou.net> <20190725220215.460-3-paul@crapouillou.net> <20190725234735.h7qmtt26qpkjw3n6@pburton-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190725_171015_363330_501B1DF8 X-CRM114-Status: GOOD ( 18.06 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-fbdev@vger.kernel.org, Liam Girdwood , James Hogan , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Sebastian Reichel , od@zcrc.me, linux-mtd@lists.infradead.org, Miquel Raynal , Lee Jones , Artur Rojek , Richard Weinberger , linux-pm@vger.kernel.org, linux-mips@vger.kernel.org, Guenter Roeck , devicetree@vger.kernel.org, Jean Delvare , Bartlomiej Zolnierkiewicz , Mark Brown , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , Vinod Koul , Rob Herring , dmaengine@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Le jeu. 25 juil. 2019 =E0 19:47, Paul Burton a = =E9crit : > Hi Paul, > = > On Thu, Jul 25, 2019 at 06:02:06PM -0400, Paul Cercueil wrote: >> Move all the platform data to devicetree. > = > Nice! :) > = >> The only bit dropped is the PWM beeper, which requires the PWM = >> driver >> to be updated. I figured it's okay to remove it here since it's = >> really >> a non-critical device, and it'll be re-introduced soon enough. > = > OK, I can see that being a price worth paying. Though it's possible to > include the binding at least for that in this series I'd be even > happier. Actually I see we already have > = > Documentation/devicetree/bindings/pwm/ingenic,jz47xx-pwm.txt > = > in mainline - what needs to change with it? The PWM driver will be updated to use the TCU clocks and the regmap = provided by the TCU driver. The PWM node will be a sub-node of the TCU one. Additionally, there is this[1] ongoing discussion about PWM which makes me uneasy about how to write the binding. So I'd rather not rush it, because once the devicetree is written, it's ABI. [1]: https://lkml.org/lkml/2019/5/22/607 >> + spi { >> + compatible =3D "spi-gpio"; >> + #address-cells =3D <1>; >> + #size-cells =3D <0>; >> + >> + sck-gpios =3D <&gpc 23 GPIO_ACTIVE_HIGH>; >> + mosi-gpios =3D <&gpc 22 GPIO_ACTIVE_HIGH>; >> + cs-gpios =3D <&gpc 21 GPIO_ACTIVE_LOW>; >> + num-chipselects =3D <1>; >> + >> + spi@0 { >> + compatible =3D "ili8960"; > = > Should this be "ilitek,ili8960"? > = > Is there a binding & driver for this submitted somewhere? If not then = > do > we need this at all? It doesn't look like the existing platform data > would actually lead to a driver being loaded so I'm wondering if we = > can > just drop this until such a driver (or at least a documented DT = > binding) > exists. I can drop it. There is no driver for it, and I'm not even sure the LB60 has a ILI8960 in the first place. > Thanks, > Paul ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/