Linux-mtd Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver
@ 2020-01-17 21:22 Miquel Raynal
  2020-02-13 15:59 ` Paul Cercueil
  0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2020-01-17 21:22 UTC (permalink / raw)
  To: Harvey Hunt, Paul Cercueil
  Cc: Richard Weinberger, Miquel Raynal, linux-mtd,
	Vignesh Raghavendra, Tudor Ambarus

This driver has no arch-specific instructions so we should be able to
compile it with any compiler.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/mtd/nand/raw/ingenic/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig b/drivers/mtd/nand/raw/ingenic/Kconfig
index e30feb56b650..485abfa3f80b 100644
--- a/drivers/mtd/nand/raw/ingenic/Kconfig
+++ b/drivers/mtd/nand/raw/ingenic/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config MTD_NAND_JZ4780
 	tristate "JZ4780 NAND controller"
-	depends on JZ4780_NEMC
+	depends on JZ4780_NEMC || COMPILE_TEST
 	help
 	  Enables support for NAND Flash connected to the NEMC on JZ4780 SoC
 	  based boards, using the BCH controller for hardware error correction.
-- 
2.20.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver
  2020-01-17 21:22 [PATCH] mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver Miquel Raynal
@ 2020-02-13 15:59 ` Paul Cercueil
  2020-02-15  5:53   ` Miquel Raynal
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Cercueil @ 2020-02-13 15:59 UTC (permalink / raw)
  To: Miquel Raynal
  Cc: Richard Weinberger, Harvey Hunt, linux-mtd, Vignesh Raghavendra,
	Tudor Ambarus

Hi Miquel, sorry for responding so late.


Le ven., janv. 17, 2020 at 22:22, Miquel Raynal 
<miquel.raynal@bootlin.com> a écrit :
> This driver has no arch-specific instructions so we should be able to
> compile it with any compiler.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Looks good to me.
Reviewed-by: Paul Cercueil <paul@crapouillou.net>

> ---
>  drivers/mtd/nand/raw/ingenic/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/Kconfig 
> b/drivers/mtd/nand/raw/ingenic/Kconfig
> index e30feb56b650..485abfa3f80b 100644
> --- a/drivers/mtd/nand/raw/ingenic/Kconfig
> +++ b/drivers/mtd/nand/raw/ingenic/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config MTD_NAND_JZ4780
>  	tristate "JZ4780 NAND controller"
> -	depends on JZ4780_NEMC
> +	depends on JZ4780_NEMC || COMPILE_TEST
>  	help
>  	  Enables support for NAND Flash connected to the NEMC on JZ4780 SoC
>  	  based boards, using the BCH controller for hardware error 
> correction.
> --
> 2.20.1
> 



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver
  2020-02-13 15:59 ` Paul Cercueil
@ 2020-02-15  5:53   ` Miquel Raynal
  0 siblings, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2020-02-15  5:53 UTC (permalink / raw)
  To: Paul Cercueil
  Cc: Richard Weinberger, Harvey Hunt, linux-mtd, Vignesh Raghavendra,
	Tudor Ambarus

Hi Paul,

Paul Cercueil <paul@crapouillou.net> wrote on Thu, 13 Feb 2020 12:59:44
-0300:

> Hi Miquel, sorry for responding so late.
> 
> 
> Le ven., janv. 17, 2020 at 22:22, Miquel Raynal <miquel.raynal@bootlin.com> a écrit :
> > This driver has no arch-specific instructions so we should be able to
> > compile it with any compiler.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> Looks good to me.
> Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Actually I had errors reported by robots so I dropped it for now. You
can see the errors that I bumped you in another thread, see:

	Subject: Fw: [miquelraynal:ecc-engine 1/60]
	ingenic_nand_drv.c:undefined  reference to `jz4780_nemc_assert'
	Date: Tue, 21 Jan 2020 16:31:57 +0100

If you find some time to fix this, that would be very appreciated and
helpful!


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 21:22 [PATCH] mtd: rawnand: ingenic: Allow to compile test the new Ingenic driver Miquel Raynal
2020-02-13 15:59 ` Paul Cercueil
2020-02-15  5:53   ` Miquel Raynal

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org
	public-inbox-index linux-mtd

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git