From: Yicong Yang <yangyicong@hisilicon.com>
To: <tudor.ambarus@microchip.com>, <linux-mtd@lists.infradead.org>
Cc: vigneshr@ti.com, sergei.shtylyov@cogentembedded.com,
richard@nod.at, john.garry@huawei.com, linuxarm@huawei.com,
yangyicong@hisilicon.com, alexander.sverdlin@nokia.com,
miquel.raynal@bootlin.com
Subject: [RFC PATCH 0/2] Add support to Disable the flash quad mode
Date: Fri, 24 Apr 2020 17:20:42 +0800 [thread overview]
Message-ID: <1587720044-49172-1-git-send-email-yangyicong@hisilicon.com> (raw)
Previously we didn't disable the flash's quad mode when it's removed
Then comes the problem that if we next time load the flash
in SPI/Dual mode, it will not be correctly enabled as the quad enable
bits has not been cleared. I validated the condition on Cypress s25fs128s1.
This series adds the capability to disable the flash's quad mode. And
restore the flash when it's removed in spi_nor_restore().
RFC:
- I cleared quad mode bit in spi_nor_restore() when flash removed or
shutdown, follow what reset 4byte address does. But I don't know if
there is a situation that the flash is in quad mode by default, then
we should disable it in probe stage.
- The issue occurs when the user switch the spi mode of the flash.
Not sure whether a situation exists.
Yicong Yang (2):
mtd: spi-nor: Add capability to disable flash quad mode
mtd: spi-nor: Disable the flash quad mode in spi_nor_restore()
drivers/mtd/spi-nor/core.c | 43 +++++++++++++++++++++++++++++++++----------
drivers/mtd/spi-nor/core.h | 8 ++++----
2 files changed, 37 insertions(+), 14 deletions(-)
--
2.8.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2020-04-24 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 9:20 Yicong Yang [this message]
2020-04-24 9:20 ` [RFC PATCH 1/2] mtd: spi-nor: Add capability to disable flash quad mode Yicong Yang
2020-04-24 13:30 ` Pratyush Yadav
2020-04-26 2:44 ` Yicong Yang
2020-04-24 9:20 ` [RFC PATCH 2/2] mtd: spi-nor: Disable the flash quad mode in spi_nor_restore() Yicong Yang
2020-04-24 13:35 ` Pratyush Yadav
2020-04-26 3:04 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587720044-49172-1-git-send-email-yangyicong@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=alexander.sverdlin@nokia.com \
--cc=john.garry@huawei.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).