From: Rickard X Andersson <Rickard.Andersson@axis.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: SV: [PATCH v2 1/2] mtd: rawnand: Add a helper for testing data interface
Date: Wed, 20 May 2020 14:52:52 +0000 [thread overview]
Message-ID: <1589986371551.27178@axis.com> (raw)
In-Reply-To: <20200520155529.3d959e96@xps13>
Hi Miquel,
Comments on two of your comments. (I am fine with all the other comments.)
> > + /*
> > + * Pass NAND_DATA_IFACE_CHECK_ONLY to only check if the
> > + * controller supports the requested timings.
> > + */
> > + ret = chip->controller->ops->setup_data_interface(chip,
> > + NAND_DATA_IFACE_CHECK_ONLY,
> > + &chip->data_interface);
>
> Could you align these lines to the opened parenthesis?
Then the lines will have 80+ characters.
> > @@ -994,9 +1020,6 @@ static int nand_choose_data_interface(struct nand_chip *chip)
> > if (chip->parameters.onfi) {
> > modes = chip->parameters.onfi->async_timing_mode;
> > } else {
> > - if (!chip->default_timing_mode)
> > - return 0;
> > -
>
> This should not be removed
Then onfi_fill_data_interface would not be called for default_timing_mode 0. (In case we have called chip->ops.choose_data_interface and got an error.).
BR,
Rickard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-05-20 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:38 [PATCH v2 1/2] mtd: rawnand: Add a helper for testing data interface Rickard Andersson
2020-05-20 13:38 ` [PATCH v2 2/2] mtd: rawnand: Add timings for Kioxia TH58NVG2S3HBAI4 Rickard Andersson
2020-05-20 21:15 ` Boris Brezillon
2020-05-20 13:55 ` [PATCH v2 1/2] mtd: rawnand: Add a helper for testing data interface Miquel Raynal
2020-05-20 14:52 ` Rickard X Andersson [this message]
2020-05-20 16:40 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589986371551.27178@axis.com \
--to=rickard.andersson@axis.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).