From: Richard Weinberger <richard@nod.at>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-mtd <linux-mtd@lists.infradead.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] ubifs: no need to check return value of debugfs_create functions
Date: Wed, 12 Jun 2019 20:53:57 +0200 (CEST) [thread overview]
Message-ID: <1642440141.89874.1560365637583.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20190612152120.GA17450@kroah.com>
Greg,
----- Ursprüngliche Mail -----
> Von: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
> An: "richard" <richard@nod.at>, "Artem Bityutskiy" <dedekind1@gmail.com>, "Adrian Hunter" <adrian.hunter@intel.com>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>
> Gesendet: Mittwoch, 12. Juni 2019 17:21:20
> Betreff: [PATCH] ubifs: no need to check return value of debugfs_create functions
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
why is it bad if we handle errors from debugfs?
At least a nice log message a la "sorry, no ubifs debuging for you"
would be nice to have.
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-12 18:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 15:21 [PATCH] ubifs: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-12 16:52 ` Mario Rugiero
2019-06-12 17:00 ` Greg Kroah-Hartman
2019-06-12 18:53 ` Richard Weinberger [this message]
2019-06-13 5:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642440141.89874.1560365637583.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).