Re: [PATCH v17 0/7] mtd: spi-nor: Add support for Infineon s25hl-t/s25hs-t

[Tudor Ambarus <tudor.ambarus@microchip.com>]

On Mon, 25 Jul 2022 12:24:58 +0300, Tudor Ambarus wrote:
> v17 introduces nor->params->addr_mode_nbytes in order to track the number
> of address bytes of current address mode. This is useful when the flash
> operates with 4B opcodes but needs the internal address mode for opcodes
> that don't have a 4B opcode correspondent. Such an example is the Infineon
> Semper chips which provide 4B opcodes for read/program/erase but do not
> provide 4B opcodes for Read/Write Any Register. These registers are indexed
> by address and require the internal address mode of the flash before
> Read/Write Any Register opcodes are issued.
> 4B opcodes are preferred over changing the flash's address mode to 4byte,
> as set_4byte_addr_mode could be done in a non-volatile way and could break
> the boot sequence. Thus we need to track the flash's internal address mode
> so that we can use the 4B opcodes together with the opcodes that don't
> have a 4B opcode correspondent.
> All other minor comments were addressed as well:
> - s/address width/ address nbytes where needed
> - "mtd: spi-nor: spansion: Add local function to discover page size" no
> longer replaces the hardcoded value of 3 for the number of address bytes.
> - few patches were dropped as they no longer made sense with the
> introduction of nor->params->addr_mode_nbytes.
> 
> [...]

Moved params->addr_mode_nbytes initialization to dedicated line,
s/int i;/unsigned int i; and applied to spi-nor/next, thanks!

[1/7] mtd: spi-nor: s/addr_width/addr_nbytes
      https://git.kernel.org/mtd/c/c452d49849d4
[2/7] mtd: spi-nor: core: Shrink the storage size of the flash_info's addr_nbytes
      https://git.kernel.org/mtd/c/aa5d980a144c
[3/7] mtd: spi-nor: Do not change nor->addr_nbytes at SFDP parsing time
      https://git.kernel.org/mtd/c/47c6f8a67f2c
[4/7] mtd: spi-nor: core: Return error code from set_4byte_addr_mode()
      https://git.kernel.org/mtd/c/08412e72afba
[5/7] mtd: spi-nor: core: Track flash's internal address mode
      https://git.kernel.org/mtd/c/d7931a215063
[6/7] mtd: spi-nor: spansion: Add local function to discover page size
      https://git.kernel.org/mtd/c/a6b50aa12796
[7/7] mtd: spi-nor: spansion: Add s25hl-t/s25hs-t IDs and fixups
      https://git.kernel.org/mtd/c/b6b23833fc42

Best regards,
-- 
Tudor Ambarus <tudor.ambarus@microchip.com>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/