From: Richard Weinberger <richard@nod.at>
To: Christophe Kerello <christophe.kerello@st.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Marek Vasut <marex@denx.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
devicetree <devicetree@vger.kernel.org>,
Richard Weinberger <richard.weinberger@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
Rob Herring <robh+dt@kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
arnd@linaro.org, Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver
Date: Tue, 30 Jun 2020 11:39:37 +0200 (CEST) [thread overview]
Message-ID: <1839269888.74591.1593509977137.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <e30abadc-83c0-f010-be36-fe8d14c4aea9@st.com>
----- Ursprüngliche Mail -----
> Von: "Christophe Kerello" <christophe.kerello@st.com>
> An: "Richard Weinberger" <richard.weinberger@gmail.com>
> CC: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>,
> "Rob Herring" <robh+dt@kernel.org>, "Mark Rutland" <mark.rutland@arm.com>, arnd@linaro.org, "Alexandre Torgue"
> <alexandre.torgue@st.com>, "Marek Vasut" <marex@denx.de>, "devicetree" <devicetree@vger.kernel.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "linux-mtd" <linux-mtd@lists.infradead.org>, linux-stm32@st-md-mailman.stormreply.com
> Gesendet: Dienstag, 30. Juni 2020 11:35:38
> Betreff: Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver
> Hi Richard,
>
> On 6/30/20 11:13 AM, Richard Weinberger wrote:
>> On Fri, Jun 12, 2020 at 5:24 PM Christophe Kerello
>> <christophe.kerello@st.com> wrote:
>>>
>>> The driver adds the support for the STMicroelectronics FMC2 EBI controller
>>> found on STM32MP SOCs.
>>>
>>> Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
>>> ---
>>> + if (!IS_ERR(rstc)) {
>>> + reset_control_assert(rstc);
>>> + reset_control_deassert(rstc);
>>
>> Shouldn't there be a small delay between assert and deassert?
>> Other than that the code looks good to me.
>>
>
> Even if I have currently not met any issue, I will add a udelay(2) to be
> safe. It will be part of v6.
Well, if it works and you are sure, please go for it. Like I said, I'm no expert in
this.
I just noticed that other users add a delay and wondered.
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-06-30 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 15:22 [PATCH v5 0/6] add STM32 FMC2 EBI controller driver Christophe Kerello
2020-06-12 15:22 ` [PATCH v5 1/6] mtd: rawnand: stm32_fmc2: do not display errors if the driver is deferred Christophe Kerello
2020-07-07 19:00 ` Miquel Raynal
2020-06-12 15:22 ` [PATCH v5 2/6] dt-bindings: mtd: update STM32 FMC2 NAND controller documentation Christophe Kerello
2020-07-07 19:00 ` Miquel Raynal
2020-06-12 15:22 ` [PATCH v5 3/6] dt-bindings: memory-controller: add STM32 FMC2 EBI " Christophe Kerello
2020-07-07 18:59 ` Miquel Raynal
2020-06-12 15:22 ` [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver Christophe Kerello
2020-06-30 9:13 ` Richard Weinberger
2020-06-30 9:35 ` Christophe Kerello
2020-06-30 9:39 ` Richard Weinberger [this message]
2020-07-07 18:59 ` Miquel Raynal
2020-06-12 15:22 ` [PATCH v5 5/6] mtd: rawnand: stm32_fmc2: use regmap APIs Christophe Kerello
2020-07-07 18:59 ` Miquel Raynal
2020-06-12 15:22 ` [PATCH v5 6/6] mtd: rawnand: stm32_fmc2: get resources from parent node Christophe Kerello
2020-07-07 18:59 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1839269888.74591.1593509977137.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=alexandre.torgue@st.com \
--cc=arnd@linaro.org \
--cc=christophe.kerello@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard.weinberger@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).