From: <Tudor.Ambarus@microchip.com>
To: <linux-mtd@lists.infradead.org>
Cc: richard@nod.at, vigneshr@ti.com, koen.vandeputte@ncentric.com,
miquel.raynal@bootlin.com
Subject: Re: [PATCH] mtd: spi-nor: add support for GigaDevice GD25D05
Date: Sat, 11 Jan 2020 15:52:27 +0000 [thread overview]
Message-ID: <1873152.psFcFxbH5H@192.168.0.113> (raw)
In-Reply-To: <20200106124624.28779-1-koen.vandeputte@ncentric.com>
Hi, Koen,
On Monday, January 6, 2020 2:46:24 PM EET Koen Vandeputte wrote:
> Tested on a MikroTik RB912UAG-5HPnD r2
>
> [ 0.641714] m25p80 spi0.0: found gd25d05, expected m25p80
> [ 0.649916] m25p80 spi0.0: gd25d05 (64 Kbytes)
> [ 0.655122] Creating 4 MTD partitions on "spi0.0":
> [ 0.660164] 0x000000000000-0x00000000c000 : "routerboot"
> [ 0.667782] 0x00000000c000-0x00000000d000 : "hard_config"
> [ 0.675073] 0x00000000d000-0x00000000e000 : "bios"
> [ 0.682613] 0x00000000e000-0x00000000f000 : "soft_config"
I'm afraid that this is not enough. You'll have to test all the flags that you
advertised. Typically one should do a read, erase, write, read-back test, and
then to exercise the lock and unlock features. If you want to be exhaustive,
you can force the controller to do the reads in single, dual or quad modes,
but if you choose to test just the best supported read mode, it is fine too.
Please specify in the commit message what you tested.
Cheers,
ta
>
> Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index f4afe123e9dc..a34fa42d47a2 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -2346,6 +2346,11 @@ static const struct flash_info spi_nor_ids[] = {
> { "mb85rs1mt", INFO(0x047f27, 0, 128 * 1024, 1, SPI_NOR_NO_ERASE)
},
>
> /* GigaDevice */
> + {
> + "gd25d05", INFO(0xc84010, 0, 64 * 1024, 1,
> + SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> + },
> {
> "gd25q16", INFO(0xc84015, 0, 64 * 1024, 32,
> SECT_4K | SPI_NOR_DUAL_READ |
SPI_NOR_QUAD_READ |
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-01-11 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 12:46 [PATCH] mtd: spi-nor: add support for GigaDevice GD25D05 Koen Vandeputte
2020-01-11 15:52 ` Tudor.Ambarus [this message]
2020-01-14 9:13 ` Koen Vandeputte
2020-02-04 14:10 ` Koen Vandeputte
2020-02-05 6:02 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1873152.psFcFxbH5H@192.168.0.113 \
--to=tudor.ambarus@microchip.com \
--cc=koen.vandeputte@ncentric.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).