From: Liang Yang <liang.yang@amlogic.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
<miquel.raynal@bootlin.com>, <richard@nod.at>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<marek.vasut@gmail.com>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>, <khilman@baylibre.com>
Subject: Re: [PATCH] mtd: rawnand: meson: Add of_node_put() before return
Date: Thu, 18 Jul 2019 11:58:46 +0800 [thread overview]
Message-ID: <1e53cc6f-59d7-9bd2-8961-ce223d5cd0d5@amlogic.com> (raw)
In-Reply-To: <20190709171640.13511-1-nishkadg.linux@gmail.com>
Hi Nishka,
On 2019/7/10 1:16, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
> drivers/mtd/nand/raw/meson_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index ea57ddcec41e..1b82b687e5a5 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -1320,6 +1320,7 @@ static int meson_nfc_nand_chips_init(struct device *dev,
> ret = meson_nfc_nand_chip_init(dev, nfc, nand_np);
> if (ret) {
> meson_nfc_nand_chip_cleanup(nfc);
> + of_node_put(nand_np);
Thank you. Looks good to me:
Acked-by: Liang Yang <liang.yang@amlogic.com>
> return ret;
> }
> }
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-07-18 3:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 17:16 [PATCH] mtd: rawnand: meson: Add of_node_put() before return Nishka Dasgupta
2019-07-18 3:58 ` Liang Yang [this message]
2019-07-25 7:55 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e53cc6f-59d7-9bd2-8961-ce223d5cd0d5@amlogic.com \
--to=liang.yang@amlogic.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=nishkadg.linux@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).