From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org,
dedekind1@gmail.com
Subject: Re: [PATCH 1/2] UBI: block: Remove __initdata from ubiblock_param_ops
Date: Wed, 19 Mar 2014 10:24:26 -0300 [thread overview]
Message-ID: <20140319132426.GB529@arch.cereza> (raw)
In-Reply-To: <1395225803-25037-1-git-send-email-richard@nod.at>
On Mar 19, Richard Weinberger wrote:
> You cannot mark these parameters as __initdata.
> Otherwise the data is gone upon module exit.
>
> Fixes:
> [ 172.045465] BUG: unable to handle kernel paging request at ffffffffa001db38
> [ 172.046020] IP: [<ffffffff81067aa4>] destroy_params+0x24/0x50
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Thanks for the fix!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-19 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 10:43 [PATCH 1/2] UBI: block: Remove __initdata from ubiblock_param_ops Richard Weinberger
2014-03-19 10:43 ` [PATCH 2/2] UBI: block: Implement kernel_param_ops->get() Richard Weinberger
2014-03-19 13:15 ` Ezequiel Garcia
2014-03-19 13:23 ` Richard Weinberger
2014-03-19 13:26 ` Richard Weinberger
2014-03-19 13:24 ` Ezequiel Garcia [this message]
2014-03-21 17:39 ` [PATCH 1/2] UBI: block: Remove __initdata from ubiblock_param_ops Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319132426.GB529@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).