From: <Tudor.Ambarus@microchip.com>
To: <broonie@kernel.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <bbrezillon@kernel.org>,
<Cyrille.Pitchen@microchip.com>, <bugalski.piotr@gmail.com>
Cc: devicetree@vger.kernel.org, Tudor.Ambarus@microchip.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 10/13] dt-bindings: spi: atmel-quadspi: make "pclk" mandatory
Date: Mon, 4 Feb 2019 10:10:01 +0000 [thread overview]
Message-ID: <20190204100910.26701-11-tudor.ambarus@microchip.com> (raw)
In-Reply-To: <20190204100910.26701-1-tudor.ambarus@microchip.com>
From: Tudor Ambarus <tudor.ambarus@microchip.com>
Naming clocks is a good practice. Make "pclk" madatory even if
we support unnamed clock in the driver, to be backward compatible
with old DTs.
Suggested-by: Boris Brezillon <bbrezillon@kernel.org>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Boris Brezillon <bbrezillon@kernel.org>
---
v4: add missing semicolon, collect R-b
v3: new patch
Documentation/devicetree/bindings/spi/atmel-quadspi.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
index e9dae6264d89..50bd257e6826 100644
--- a/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
+++ b/Documentation/devicetree/bindings/spi/atmel-quadspi.txt
@@ -9,6 +9,7 @@ Required properties:
- qspi_mmap: memory mapped address space
- interrupts: Should contain the interrupt for the device.
- clocks: The phandle of the clock needed by the QSPI controller.
+- clock-names: Should contain "pclk" for the peripheral clock.
- #address-cells: Should be <1>.
- #size-cells: Should be <0>.
@@ -20,6 +21,7 @@ spi@f0020000 {
reg-names = "qspi_base", "qspi_mmap";
interrupts = <52 IRQ_TYPE_LEVEL_HIGH 7>;
clocks = <&pmc PMC_TYPE_PERIPHERAL 52>;
+ clock-names = "pclk";
#address-cells = <1>;
#size-cells = <0>;
pinctrl-names = "default";
--
2.9.5
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-04 11:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 10:09 [PATCH v4 00/13] spi: atmel-quadspi: introduce sam9x60 qspi controller Tudor.Ambarus
2019-02-04 10:09 ` [PATCH v4 01/13] spi: atmel-quadspi: cache MR value to avoid a write access Tudor.Ambarus
2019-02-04 14:00 ` Boris Brezillon
2019-02-04 10:09 ` [PATCH v4 02/13] spi: atmel-quadspi: order header files inclusion alphabetically Tudor.Ambarus
2019-02-04 10:09 ` [PATCH v4 03/13] spi: atmel-quadspi: drop wrappers for iomem accesses Tudor.Ambarus
2019-02-04 10:09 ` [PATCH v4 04/13] spi: atmel-quadspi: fix naming scheme Tudor.Ambarus
2019-02-04 10:09 ` [PATCH v4 05/13] spi: atmel-quadspi: remove unnecessary cast Tudor.Ambarus
2019-02-04 10:09 ` [PATCH v4 06/13] spi: atmel-quadspi: return appropriate error code Tudor.Ambarus
2019-02-04 10:09 ` [PATCH v4 07/13] spi: atmel-quadspi: switch to SPDX license identifiers Tudor.Ambarus
2019-02-04 10:09 ` [PATCH v4 08/13] spi: atmel-quadspi: rework transfer macros Tudor.Ambarus
2019-02-04 14:01 ` Boris Brezillon
2019-02-04 10:09 ` [PATCH v4 09/13] dt-bindings: spi: atmel-quadspi: update example to new clock binding Tudor.Ambarus
2019-02-04 10:10 ` Tudor.Ambarus [this message]
2019-02-04 10:10 ` [PATCH v4 11/13] spi: atmel-quadspi: add support for named peripheral clock Tudor.Ambarus
2019-02-04 10:10 ` [PATCH v4 12/13] dt-bindings: spi: atmel-quadspi: QuadSPI driver for Microchip SAM9X60 Tudor.Ambarus
2019-02-04 10:10 ` [PATCH v4 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller Tudor.Ambarus
2019-02-04 14:16 ` Boris Brezillon
2019-02-04 14:28 ` Tudor.Ambarus
2019-02-04 14:37 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204100910.26701-11-tudor.ambarus@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Cyrille.Pitchen@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=bugalski.piotr@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).