* Re: [PATCH v3 1/2] drivers/mtd: Use mtd->name when registering nvmem device
[not found] <20190208151419.1800-1-aneesh.kumar@linux.ibm.com>
@ 2019-02-10 12:55 ` Boris Brezillon
2019-02-11 10:56 ` Aneesh Kumar K.V
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2019-02-10 12:55 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: linuxppc-dev, Alban Bedel, linux-mtd
Hello Aneesh,
On Fri, 8 Feb 2019 20:44:18 +0530
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
> With this patch, we use the mtd->name instead of concatenating the name with '0'
>
> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API")
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
You forgot to Cc the MTD ML and maintainers. Can you please send a new
version?
Thanks,
Boris
> ---
> drivers/mtd/mtdcore.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 999b705769a8..3ef01baef9b6 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -507,6 +507,7 @@ static int mtd_nvmem_add(struct mtd_info *mtd)
> {
> struct nvmem_config config = {};
>
> + config.id = -1;
> config.dev = &mtd->dev;
> config.name = mtd->name;
> config.owner = THIS_MODULE;
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] drivers/mtd: Use mtd->name when registering nvmem device
2019-02-10 12:55 ` [PATCH v3 1/2] drivers/mtd: Use mtd->name when registering nvmem device Boris Brezillon
@ 2019-02-11 10:56 ` Aneesh Kumar K.V
2019-02-11 11:16 ` Boris Brezillon
0 siblings, 1 reply; 5+ messages in thread
From: Aneesh Kumar K.V @ 2019-02-11 10:56 UTC (permalink / raw)
To: Boris Brezillon; +Cc: linuxppc-dev, Alban Bedel, linux-mtd
On 2/10/19 6:25 PM, Boris Brezillon wrote:
> Hello Aneesh,
>
> On Fri, 8 Feb 2019 20:44:18 +0530
> "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
>
>> With this patch, we use the mtd->name instead of concatenating the name with '0'
>>
>> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API")
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>
> You forgot to Cc the MTD ML and maintainers. Can you please send a new
> version?
>
linux-mtd list is on CC: Is that not sufficient?
-aneesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] drivers/mtd: Use mtd->name when registering nvmem device
2019-02-11 10:56 ` Aneesh Kumar K.V
@ 2019-02-11 11:16 ` Boris Brezillon
2019-02-11 13:34 ` Aneesh Kumar K.V
0 siblings, 1 reply; 5+ messages in thread
From: Boris Brezillon @ 2019-02-11 11:16 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: linuxppc-dev, Alban Bedel, linux-mtd
On Mon, 11 Feb 2019 16:26:38 +0530
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
> On 2/10/19 6:25 PM, Boris Brezillon wrote:
> > Hello Aneesh,
> >
> > On Fri, 8 Feb 2019 20:44:18 +0530
> > "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
> >
> >> With this patch, we use the mtd->name instead of concatenating the name with '0'
> >>
> >> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API")
> >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> >
> > You forgot to Cc the MTD ML and maintainers. Can you please send a new
> > version?
> >
>
> linux-mtd list is on CC: Is that not sufficient?
Not in your original email, I added it in my reply.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] drivers/mtd: Use mtd->name when registering nvmem device
2019-02-11 11:16 ` Boris Brezillon
@ 2019-02-11 13:34 ` Aneesh Kumar K.V
0 siblings, 0 replies; 5+ messages in thread
From: Aneesh Kumar K.V @ 2019-02-11 13:34 UTC (permalink / raw)
To: Boris Brezillon; +Cc: linuxppc-dev, Alban Bedel, linux-mtd
On 2/11/19 4:46 PM, Boris Brezillon wrote:
> On Mon, 11 Feb 2019 16:26:38 +0530
> "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
>
>> On 2/10/19 6:25 PM, Boris Brezillon wrote:
>>> Hello Aneesh,
>>>
>>> On Fri, 8 Feb 2019 20:44:18 +0530
>>> "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote:
>>>
>>>> With this patch, we use the mtd->name instead of concatenating the name with '0'
>>>>
>>>> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API")
>>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>>>
>>> You forgot to Cc the MTD ML and maintainers. Can you please send a new
>>> version?
>>>
>>
>> linux-mtd list is on CC: Is that not sufficient?
>
> Not in your original email, I added it in my reply.
>
Sorry about that. I will now resend with linux-mtd on CC: I missed that
earlier.
-aneesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/2] drivers/mtd: Use mtd->name when registering nvmem device
@ 2019-02-11 13:33 Aneesh Kumar K.V
0 siblings, 0 replies; 5+ messages in thread
From: Aneesh Kumar K.V @ 2019-02-11 13:33 UTC (permalink / raw)
To: Alban Bedel, linuxppc-dev, Boris Brezillon, linux-mtd; +Cc: Aneesh Kumar K.V
With this patch, we use the mtd->name instead of concatenating the name with '0'
Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API")
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
---
drivers/mtd/mtdcore.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 999b705769a8..3ef01baef9b6 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -507,6 +507,7 @@ static int mtd_nvmem_add(struct mtd_info *mtd)
{
struct nvmem_config config = {};
+ config.id = -1;
config.dev = &mtd->dev;
config.name = mtd->name;
config.owner = THIS_MODULE;
--
2.20.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-02-11 13:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190208151419.1800-1-aneesh.kumar@linux.ibm.com>
2019-02-10 12:55 ` [PATCH v3 1/2] drivers/mtd: Use mtd->name when registering nvmem device Boris Brezillon
2019-02-11 10:56 ` Aneesh Kumar K.V
2019-02-11 11:16 ` Boris Brezillon
2019-02-11 13:34 ` Aneesh Kumar K.V
2019-02-11 13:33 Aneesh Kumar K.V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).