From: "Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com>
To: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Marek Vasut <marek.vasut@gmail.com>,
"Sverdlin,
Alexander \(Nokia - DE/Ulm\)" <alexander.sverdlin@nokia.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH 1/2] mtd: spi-nor: Fix comment of spi_nor_find_best_erase_type()
Date: Tue, 19 Mar 2019 16:57:13 +0000 [thread overview]
Message-ID: <20190319165651.23695-2-alexander.sverdlin@nokia.com> (raw)
In-Reply-To: <20190319165651.23695-1-alexander.sverdlin@nokia.com>
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Erase types are sorted *smallest* type first, refer to
spi_nor_sort_erase_mask().
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 6e13bbd1aaa5..c3598f0571cc 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -739,7 +739,7 @@ spi_nor_find_best_erase_type(const struct spi_nor_erase_map *map,
u8 erase_mask = region->offset & SNOR_ERASE_TYPE_MASK;
/*
- * Erase types are ordered by size, with the biggest erase type at
+ * Erase types are ordered by size, with the smallest erase type at
* index 0.
*/
for (i = SNOR_ERASE_TYPE_MAX - 1; i >= 0; i--) {
--
2.19.2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-03-19 16:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 11:20 [PATCH 0/2] spi-nor: Drop uniform erase Sverdlin, Alexander (Nokia - DE/Ulm)
2019-01-24 11:21 ` [PATCH 1/2] mtd: spi-nor: Fix comment of spi_nor_find_best_erase_type() Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-19 16:29 ` Tudor.Ambarus
2019-03-19 16:57 ` [PATCH 0/2] spi-nor: Drop uniform erase Sverdlin, Alexander (Nokia - DE/Ulm)
2019-03-19 16:57 ` Sverdlin, Alexander (Nokia - DE/Ulm) [this message]
2019-03-20 6:52 ` [PATCH 1/2] mtd: spi-nor: Fix comment of spi_nor_find_best_erase_type() Tudor.Ambarus
2019-03-21 16:47 ` Tudor.Ambarus
2019-03-19 16:57 ` [PATCH 2/2] mtd: spi-nor: Always use biggest erase size Sverdlin, Alexander (Nokia - DE/Ulm)
2019-01-24 11:21 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2019-02-28 17:00 ` Tudor.Ambarus
2019-03-01 9:50 ` Sverdlin, Alexander (Nokia - DE/Ulm)
2020-01-13 15:34 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319165651.23695-2-alexander.sverdlin@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).