Linux-mtd Archive on lore.kernel.org
 help / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Kees Cook <keescook@chromium.org>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs
Date: Tue, 16 Apr 2019 19:24:08 +0200
Message-ID: <20190416192408.0e321563@xps13> (raw)
In-Reply-To: <ee1f8c4a-92b0-db9d-6110-3acadeb9e457@embeddedor.com>

Hi Gustavo,

"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote on Mon, 15 Apr
2019 07:57:11 -0500:

> Hi Miquel,
> 
> On 4/15/19 3:44 AM, Miquel Raynal wrote:
> > Hi Gustavo,
> > 
> > "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote on Wed, 10 Apr
> > 2019 16:16:51 -0500:
> >   
> >> Hi all,
> >>
> >> If no one cares I'll add this to my tree for 5.2.  
> > 
> > Which tree are you talking about?
> >   
> 
> This one:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
> 
> > Please let the MTD maintainers take patches through their tree. We
> > might be late but this is definitely not a good reason to bypass us.
> >   
> It's a bit confusing when patches are being ignored for more than two
> months:
> 
> https://lore.kernel.org/patchwork/patch/1040099/
> https://lore.kernel.org/patchwork/patch/1040100/
> https://lore.kernel.org/patchwork/patch/1040098/
> 

Patches posted at -rc6 right before the last release? Come on! Gustavo,
we always spend more time for you than for other contributors because we
do not trust your changes. We could apply them blindly but we don't do
that for other (worthy) contributions, so why shall we do it for you?

I think you could at least flag these changes as "automatic and
unverified" in the commit log so that when git blaming, people could
know that the additional explicit /* fallthrough */ comment might be
wrong and was just added in order to limit the number of warnings when
enabling the extra GCC warning.

> Certainly, Richard Weinberger replied to this one. But I couldn't
> find a tree to which this patch was applied, in case it actually
> was.
> 
> It's a common practice for maintainers to reply saying that a patch
> has been finally applied, and in most cases they also explicitly
> mention the tree and branch to which it was applied. All this info
> is really helpful for people working all over the tree.

It is common practice for contributors to understand what they
are doing before submitting a change and this is something that you
clearly don't try to do.


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 18:02 Gustavo A. R. Silva
2019-03-20 20:20 ` Gustavo A. R. Silva
2019-03-20 21:05   ` Richard Weinberger
2019-03-20 21:23     ` Gustavo A. R. Silva
2019-03-20 23:25       ` Richard Weinberger
2019-03-20 23:36         ` Gustavo A. R. Silva
2019-04-10 21:16   ` Gustavo A. R. Silva
2019-04-15  8:44     ` Miquel Raynal
2019-04-15 12:57       ` Gustavo A. R. Silva
2019-04-16 17:24         ` Miquel Raynal [this message]
2019-04-16 20:49           ` Gustavo A. R. Silva
2019-05-07 14:54             ` Gustavo A. R. Silva
2019-05-07 15:49               ` Richard Weinberger
2019-05-07 15:59                 ` Gustavo A. R. Silva
2019-05-09  6:53                   ` Miquel Raynal
2019-04-10 21:46 ` Kees Cook

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416192408.0e321563@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mtd Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \
		linux-mtd@lists.infradead.org linux-mtd@archiver.kernel.org
	public-inbox-index linux-mtd


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd


AGPL code for this site: git clone https://public-inbox.org/ public-inbox