From: Miquel Raynal <miquel.raynal@bootlin.com> To: Mason Yang <masonccyang@mxic.com.tw> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, christophe.kerello@st.com, juliensu@mxic.com.tw, bbrezillon@kernel.org, marcel.ziswiler@toradex.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-spi@vger.kernel.org, marek.vasut@gmail.com, paul.burton@mips.com, broonie@kernel.org, geert@linux-m68k.org, stefan@agner.ch, linux-mtd@lists.infradead.org, richard@nod.at, liang.yang@amlogic.com, computersforpeace@gmail.com, dwmw2@infradead.org, zhengxunli@mxic.com.tw Subject: Re: [PATCH v3 4/4] dt-bindings: mfd: Document Macronix MX25F0A controller bindings Date: Sun, 12 May 2019 15:23:40 +0200 Message-ID: <20190512152328.49576a0f@xps13> (raw) In-Reply-To: <1555320234-15802-5-git-send-email-masonccyang@mxic.com.tw> Hi Mason, Mason Yang <masonccyang@mxic.com.tw> wrote on Mon, 15 Apr 2019 17:23:54 +0800: > Document the bindings used by the Macronix MX25F0A MFD controller. > > Signed-off-by: Mason Yang <masonccyang@mxic.com.tw> > --- > .../devicetree/bindings/mfd/mxic-mx25f0a.txt | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mxic-mx25f0a.txt > > diff --git a/Documentation/devicetree/bindings/mfd/mxic-mx25f0a.txt b/Documentation/devicetree/bindings/mfd/mxic-mx25f0a.txt > new file mode 100644 > index 0000000..7f3e0f8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mxic-mx25f0a.txt > @@ -0,0 +1,51 @@ > +Macronix MX25F0A MultiFunction Device Tree Bindings > +---------------------------------------------------- > + > +MX25F0A is a MultiFunction Device with SPI and raw NAND, which > +supports either spi host controller or raw nand controller. Acronyms in plain English should be in upper case. > + > +Required properties: > +- compatible: should be "mxic,mx25f0a" > +- #address-cells: should be 1 > +- #size-cells: should be 0 > +- reg: should contain 2 entries, one for the registers and one for the direct > + mapping area in SPI mode. > +- reg-names: should contain "regs" and "dirmap" > +- interrupts: interrupt line connected to this MFD controller > +- SPI controller driver: > + - clock-names: should contain "ps_clk", "send_clk" and > + "send_dly_clk" > + - clocks: should contain 3 entries for the "ps_clk", "send_clk" > + and "send_dly_clk" clocks > + > +- Raw nand controller driver. > + - nand-ecc-mode = "soft"; > + - nand-ecc-algo = "bch"; > + > +Example: > + > + mxic: mx25f0a@43c30000 { > + compatible = "mxic,mx25f0a"; > + reg = <0x43c30000 0x10000>, <0xa0000000 0x4000000>; > + reg-names = "regs", "dirmap"; > + > + /* spi */ > + clocks = <&clkwizard 0>, <&clkwizard 1>, <&clkc 15>; > + clock-names = "send_clk", "send_dly_clk", "ps_clk"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <25000000>; > + spi-tx-bus-width = <4>; > + spi-rx-bus-width = <4>; > + }; > + > + /* nand */ > + nand-ecc-mode = "soft"; > + nand-ecc-algo = "bch"; > + nand-ecc-step-size = <512>; > + nand-ecc-strength = <8>; Any reason to enforce 512B/8b correction? Why not letting the core choose for you depending on the NAND chip's requirements? Anyway, I think you can have only one or the other (NAND or SPI), not both, and you probably should have a compatible or a property to tell the kernel which one you are using, right? Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply index Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-15 9:23 [PATCH v3 0/4] Add Macronix MX25F0A MFD driver for raw nand and spi Mason Yang 2019-04-15 9:23 ` [PATCH v3 1/4] mfd: Add Macronix MX25F0A MFD controller driver Mason Yang 2019-05-12 13:08 ` Miquel Raynal 2019-05-15 6:46 ` masonccyang 2019-04-15 9:23 ` [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller Mason Yang 2019-05-12 13:18 ` Miquel Raynal 2019-05-15 8:48 ` masonccyang 2019-05-15 12:08 ` Miquel Raynal [not found] ` <OF8A566F14.A2F0F576-ON482583FB.002E7E32-482583FB.003068B1@LocalDomain> 2019-05-15 9:18 ` masonccyang 2019-05-17 9:30 ` masonccyang 2019-05-20 12:23 ` Miquel Raynal 2019-05-23 8:58 ` masonccyang 2019-05-27 12:42 ` Miquel Raynal 2019-05-29 3:12 ` masonccyang 2019-06-17 12:35 ` Miquel Raynal 2019-06-18 1:24 ` masonccyang 2019-06-18 6:14 ` Boris Brezillon 2019-06-18 7:29 ` Boris Brezillon 2019-06-19 8:04 ` masonccyang 2019-06-19 8:09 ` Miquel Raynal 2019-06-19 8:48 ` masonccyang 2019-06-24 9:05 ` masonccyang 2019-06-19 8:15 ` Boris Brezillon 2019-06-19 8:55 ` masonccyang 2019-06-19 9:06 ` Boris Brezillon 2019-06-24 8:55 ` masonccyang 2019-04-15 9:23 ` [PATCH v3 3/4] spi: Patch Macronix SPI controller driver according to MX25F0A MFD driver Mason Yang 2019-04-19 14:51 ` Mark Brown [not found] ` <OF7742B4A9.445066F6-ON482583EC.0037E377-482583EC.0039125B@mxic.com.tw> 2019-05-02 2:41 ` Mark Brown 2019-04-15 9:23 ` [PATCH v3 4/4] dt-bindings: mfd: Document Macronix MX25F0A controller bindings Mason Yang 2019-04-26 22:41 ` Rob Herring 2019-05-12 13:23 ` Miquel Raynal [this message] 2019-05-15 7:36 ` masonccyang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190512152328.49576a0f@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=bbrezillon@kernel.org \ --cc=broonie@kernel.org \ --cc=christophe.kerello@st.com \ --cc=computersforpeace@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=geert@linux-m68k.org \ --cc=juliensu@mxic.com.tw \ --cc=lee.jones@linaro.org \ --cc=liang.yang@amlogic.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=marcel.ziswiler@toradex.com \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=masonccyang@mxic.com.tw \ --cc=paul.burton@mips.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=stefan@agner.ch \ --cc=zhengxunli@mxic.com.tw \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mtd Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mtd/0 linux-mtd/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mtd linux-mtd/ https://lore.kernel.org/linux-mtd \ linux-mtd@lists.infradead.org public-inbox-index linux-mtd Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-mtd AGPL code for this site: git clone https://public-inbox.org/public-inbox.git