From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: kernel@pengutronix.de, Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Vinod Koul <vkoul@kernel.org>,
linux-mtd@lists.infradead.org, NXP Linux Team <linux-imx@nxp.com>,
Fabio Estevam <festevam@gmail.com>, Han Xu <han.xu@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3 00/14] Implement exec_op for GPMI nand driver
Date: Mon, 20 May 2019 16:30:38 +0200 [thread overview]
Message-ID: <20190520163038.7f38b54a@xps13> (raw)
In-Reply-To: <20190425125643.29990-1-s.hauer@pengutronix.de>
Hi Sascha,
Sascha Hauer <s.hauer@pengutronix.de> wrote on Thu, 25 Apr 2019
14:56:29 +0200:
> The GPMI nand driver suffers from very poor performance. The read
> performance can be roughly doubled with two steps: First is to use
> runtime PM for controlling the clocks which prevents the driver from
> spending a good amount of time en/disabling the clocks. The second step
> is to implement exec_op which allows us to combine the steps necessary
> to do a page read into a single DMA transaction.
>
> I would prefer to let this go through the mtd tree with the ack of the
> dmaengine maintainers
>
> changes since v2:
>
> - s/dma/dmaengine in dmaengine specific patches
> - s/nand/NAND/
> - Add reviewed-by Miquel
> - Add Acked-by Vinod
>
> changes since v1:
>
> - tested and fixed on i.MX28
> - remove debugging leftover
> - Add mxs dma specific header files to put the oddities of the mxs dma
> driver in
> - Turn off BCH engine interrupts when not needed as they result in
> calling complete() on an uninitialized completion. This crashes
> on i.MX28
>
> Sascha Hauer (14):
> mtd: rawnand: export NAND operation tracer
> mtd: rawnand: fsmc: Use nand_op_trace for operation tracing
> mtd: rawnand: gpmi: move all driver code into single file
> mtd: rawnand: gpmi: remove unused variable
> mtd: rawnand: gpmi: Remove unnecessary variables
> mtd: rawnand: gpmi: read buf in nand_read_page_op
> mtd: rawnand: gpmi: remove unused parameters
> mtd: rawnand: gpmi: Drop unnecessary restoring of previous chipselection
> mtd: rawnand: gpmi: use runtime PM to manage clocks
> dmaengine: mxs: Drop unnecessary flag
> mtd: rawnand: gpmi: drop unnecessary flag
> dmaengine: mxs: Add header file to be shared with gpmi nand driver
> dmaengine: mxs: rename custom flag
> mtd: rawnand: gpmi: Implement exec_op
>
> drivers/dma/mxs-dma.c | 25 +-
> drivers/mtd/nand/raw/fsmc_nand.c | 19 +-
> drivers/mtd/nand/raw/gpmi-nand/Makefile | 1 -
> drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c | 936 -----------
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 1687 ++++++++++++++------
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h | 64 +-
> drivers/mtd/nand/raw/nand_base.c | 30 +-
> include/linux/dma/mxs-dma.h | 24 +
> include/linux/mtd/rawnand.h | 37 +
> 9 files changed, 1264 insertions(+), 1559 deletions(-)
> delete mode 100644 drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> create mode 100644 include/linux/dma/mxs-dma.h
>
Please ignore the previous message telling the patch was applied, I
have to manually fix all the conflicts, I canceled the operation: would
you mind rebasing on v5.2-rc1 and respin?
Thanks and sorry for the trouble,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-05-20 14:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 12:56 [PATCH v3 00/14] Implement exec_op for GPMI nand driver Sascha Hauer
2019-04-25 12:56 ` [PATCH 01/14] mtd: rawnand: export NAND operation tracer Sascha Hauer
2019-04-25 12:56 ` [PATCH 02/14] mtd: rawnand: fsmc: Use nand_op_trace for operation tracing Sascha Hauer
2019-05-20 14:21 ` Miquel Raynal
2019-04-25 12:56 ` [PATCH 03/14] mtd: rawnand: gpmi: move all driver code into single file Sascha Hauer
2019-04-25 12:56 ` [PATCH 04/14] mtd: rawnand: gpmi: remove unused variable Sascha Hauer
2019-04-25 12:56 ` [PATCH 05/14] mtd: rawnand: gpmi: Remove unnecessary variables Sascha Hauer
2019-04-25 12:56 ` [PATCH 06/14] mtd: rawnand: gpmi: read buf in nand_read_page_op Sascha Hauer
2019-04-25 12:56 ` [PATCH 07/14] mtd: rawnand: gpmi: remove unused parameters Sascha Hauer
2019-04-25 12:56 ` [PATCH 08/14] mtd: rawnand: gpmi: Drop unnecessary restoring of previous chipselection Sascha Hauer
2019-04-25 12:56 ` [PATCH 09/14] mtd: rawnand: gpmi: use runtime PM to manage clocks Sascha Hauer
2019-04-25 12:56 ` [PATCH 10/14] dmaengine: mxs: Drop unnecessary flag Sascha Hauer
2019-04-25 12:56 ` [PATCH 11/14] mtd: rawnand: gpmi: drop " Sascha Hauer
2019-04-25 12:56 ` [PATCH 12/14] dmaengine: mxs: Add header file to be shared with gpmi nand driver Sascha Hauer
2019-04-25 12:56 ` [PATCH 13/14] dmaengine: mxs: rename custom flag Sascha Hauer
2019-04-25 12:56 ` [PATCH 14/14] mtd: rawnand: gpmi: Implement exec_op Sascha Hauer
2019-05-20 14:30 ` Miquel Raynal [this message]
2019-05-21 7:12 ` [PATCH v3 00/14] Implement exec_op for GPMI nand driver Sascha Hauer
2019-05-21 7:31 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520163038.7f38b54a@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=festevam@gmail.com \
--cc=han.xu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).