linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	linux-mtd@lists.infradead.org, NXP Linux Team <linux-imx@nxp.com>,
	kernel@pengutronix.de, Richard Weinberger <richard@nod.at>,
	Han Xu <han.xu@nxp.com>, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 03/14] mtd: rawnand: gpmi: move all driver code into single file
Date: Tue, 21 May 2019 10:40:41 +0200	[thread overview]
Message-ID: <20190521104041.481b13c1@xps13> (raw)
In-Reply-To: <20190521083421.l5gvl3xrrbwd352j@pengutronix.de>

Hi Sascha,

Sascha Hauer <s.hauer@pengutronix.de> wrote on Tue, 21 May 2019
10:34:21 +0200:

> On Tue, May 21, 2019 at 09:06:32AM +0200, Sascha Hauer wrote:
> > This moves the whole driver into a single C file. The filename gpmi-lib
> > implies that it implements library functions, but in fact there are
> > several cases where functions in gpmi-lib.c call back into functions in
> > gpmi-nand.c. With this one has to constantly jump between those two
> > files, so moving it into a single file improves readability, even when
> > the file gets quite large.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  drivers/mtd/nand/raw/gpmi-nand/Makefile    |    1 -
> >  drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c  |  923 --------------
> >  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 1269 +++++++++++++++++---
> >  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h |   34 -
> >  4 files changed, 1095 insertions(+), 1132 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/raw/gpmi-nand/Makefile b/drivers/mtd/nand/raw/gpmi-nand/Makefile
> > index 3a462487c35e..60c7b6f87c53 100644
> > --- a/drivers/mtd/nand/raw/gpmi-nand/Makefile
> > +++ b/drivers/mtd/nand/raw/gpmi-nand/Makefile
> > @@ -1,3 +1,2 @@
> >  obj-$(CONFIG_MTD_NAND_GPMI_NAND) += gpmi_nand.o
> >  gpmi_nand-objs += gpmi-nand.o
> > -gpmi_nand-objs += gpmi-lib.o
> > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > index a8b26d2e793c..bcc92185384a 100644
> > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > @@ -9,926 +9,3 @@
> >  #include <linux/clk.h>
> >  #include <linux/slab.h>  
> 
> Oops, gpmi-lib.c should be completely removed here. Please use the
> following version of this patch.
> 

Done.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-05-21  8:41 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  7:06 [PATCH v4 00/14] Implement exec_op for GPMI nand driver Sascha Hauer
2019-05-21  7:06 ` [PATCH 01/14] mtd: rawnand: export NAND operation tracer Sascha Hauer
2019-06-03  8:04   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 02/14] mtd: rawnand: fsmc: Use nand_op_trace for operation tracing Sascha Hauer
2019-06-03  8:04   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 03/14] mtd: rawnand: gpmi: move all driver code into single file Sascha Hauer
2019-05-21  8:34   ` Sascha Hauer
2019-05-21  8:40     ` Miquel Raynal [this message]
2019-06-03  8:04   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 04/14] mtd: rawnand: gpmi: remove unused variable Sascha Hauer
2019-06-03  8:04   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 05/14] mtd: rawnand: gpmi: Remove unnecessary variables Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 06/14] mtd: rawnand: gpmi: read buf in nand_read_page_op Sascha Hauer
2019-05-21  7:06 ` [PATCH 07/14] mtd: rawnand: gpmi: remove unused parameters Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 08/14] mtd: rawnand: gpmi: Drop unnecessary restoring of previous chipselection Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 09/14] mtd: rawnand: gpmi: use runtime PM to manage clocks Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 10/14] dmaengine: mxs: Drop unnecessary flag Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 11/14] mtd: rawnand: gpmi: drop " Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 12/14] dmaengine: mxs: Add header file to be shared with gpmi nand driver Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 13/14] dmaengine: mxs: rename custom flag Sascha Hauer
2019-06-03  8:03   ` Miquel Raynal
2019-05-21  7:06 ` [PATCH 14/14] mtd: rawnand: gpmi: Implement exec_op Sascha Hauer
2019-06-03  8:02   ` Miquel Raynal
2019-05-21  8:19 ` [PATCH v4 00/14] Implement exec_op for GPMI nand driver Sascha Hauer
2019-05-21  8:33   ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2019-04-25 12:56 [PATCH v3 " Sascha Hauer
2019-04-25 12:56 ` [PATCH 03/14] mtd: rawnand: gpmi: move all driver code into single file Sascha Hauer
2019-04-09 11:34 [PATCH v2 00/14] Implement exec_op for GPMI nand driver Sascha Hauer
2019-04-09 11:34 ` [PATCH 03/14] mtd: rawnand: gpmi: move all driver code into single file Sascha Hauer
2019-04-17 10:23   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521104041.481b13c1@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=festevam@gmail.com \
    --cc=han.xu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).