From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F87FC31E51 for ; Tue, 18 Jun 2019 07:29:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54CAF2080C for ; Tue, 18 Jun 2019 07:29:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j4kKjCIF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54CAF2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qdb9tEnABeDGfqYfmThCxBtz6MXJc2jcDTn6FCY4+wc=; b=j4kKjCIFxCwwlN i9VJ89DHTw33cG7aborWv5fUwnrWdwCk0hnPn/lubUIx7JXmVjC2hko6b7YuMPqoa9y1TetB+1dRB iC0PiwjYMG7dWvDU6eKo9wRlicU/ll4aYdUEPvUa9Q6UbsfPGd3a6IdqrnofxFelrxKO36e71jteR ZG7xYk5cgjXrq1DN5LCTJxOYB0tHBIPcliXupMYFkihhuGjH8tpNJakbowKfzcjlZVSUhKTDiossT cN6XWl74g1ubbNh3a6u4YGkGH5j+GAvFbR7KxV+EsEJHw2MZwmfF63SxwEGkC0vmyRdMSWgkiO/0T 8j1OoCuEWkBG+LCfhIiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hd8YI-0003ru-Aq; Tue, 18 Jun 2019 07:29:10 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hd8YF-0003rP-3h for linux-mtd@lists.infradead.org; Tue, 18 Jun 2019 07:29:08 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 6B5CB260C4A; Tue, 18 Jun 2019 08:29:04 +0100 (BST) Date: Tue, 18 Jun 2019 09:29:01 +0200 From: Boris Brezillon To: masonccyang@mxic.com.tw Subject: Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller Message-ID: <20190618092901.3bdd9f61@collabora.com> In-Reply-To: <20190618081436.5d488320@collabora.com> References: <1555320234-15802-1-git-send-email-masonccyang@mxic.com.tw> <1555320234-15802-3-git-send-email-masonccyang@mxic.com.tw> <20190512151820.4f2dd9da@xps13> <20190520142333.390091d5@xps13> <20190527144250.71908bd9@xps13> <20190617143510.4ded5728@xps13> <20190618081436.5d488320@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_002907_288866_1FD67CF9 X-CRM114-Status: GOOD ( 12.13 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, christophe.kerello@st.com, marcel.ziswiler@toradex.com, stefan@agner.ch, liang.yang@amlogic.com, linux-mtd@lists.infradead.org, Miquel Raynal , lee.jones@linaro.org, richard@nod.at, marek.vasut@gmail.com, geert@linux-m68k.org, devicetree@vger.kernel.org, robh+dt@kernel.org, bbrezillon@kernel.org, juliensu@mxic.com.tw, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, paul.burton@mips.com, broonie@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, zhengxunli@mxic.com.tw Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 18 Jun 2019 08:14:36 +0200 Boris Brezillon wrote: > > > > > > > > > > > > How to make all #CS keep high for NAND to enter > > > > > > low-power standby mode if driver don't use "legacy.select_chip()" > > ? > > > > > > > > > > See commit 02b4a52604a4 ("mtd: rawnand: Make ->select_chip() > > optional > > > > > when ->exec_op() is implemented") which states: > > > > > > > > > > "When [->select_chip() is] not implemented, the core is > > assuming > > > > > the CS line is automatically asserted/deasserted by the driver > > > > > ->exec_op() implementation." > > > > > > > > > > Of course, the above is right only when the controller driver > > supports > > > > > the ->exec_op() interface. > > > > > > > > Currently, it seems that we will get the incorrect data and error > > > > operation due to CS in error toggling if CS line is controlled in > > > > ->exec_op(). Oh, and please provide the modifications you added on top of this patch. Right now we're speculating on what you've done which is definitely not an efficient way to debug this sort of issues. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/