From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH] ubifs: Correctly initialize c->min_log_bytes
Date: Thu, 25 Jul 2019 23:04:29 +0200 [thread overview]
Message-ID: <20190725210429.2aumbkpcfh4kzp2e@pengutronix.de> (raw)
In-Reply-To: <20190725205627.31313-1-richard@nod.at>
Hello Richard,
On Thu, Jul 25, 2019 at 10:56:27PM +0200, Richard Weinberger wrote:
> Currently on a freshly mounted UBIFS, c->min_log_bytes is 0.
> This can lead to a log overrun and make commits fail.
>
> Recent kernels will report the following assert:
> UBIFS assert failed: c->lhead_lnum != c->ltail_lnum, in fs/ubifs/log.c:412
>
> c->min_log_bytes can have two states, 0 and c->leb_size.
> It controls how much bytes of the log area are reserved for non-bud
> nodes such as commit nodes.
>
> After a commit it has to be set to c->leb_size such that we have always
> enought space for a commit. While a commit runs it can be 0 to make the
s/enought/enough/
> remaining bytes of the log available to writers.
>
> Having it set to 0 right after mount is wrong since no space for commits
> is reserved.
>
> Reported-and-tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Thanks for your support
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-07-25 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 20:56 [PATCH] ubifs: Correctly initialize c->min_log_bytes Richard Weinberger
2019-07-25 21:03 ` Richard Weinberger
2019-07-25 21:04 ` Uwe Kleine-König [this message]
2019-07-31 7:42 ` Uwe Kleine-König
2019-07-31 8:07 ` Richard Weinberger
2019-07-31 8:22 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725210429.2aumbkpcfh4kzp2e@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).