From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D89C433FF for ; Wed, 7 Aug 2019 16:06:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67A7921871 for ; Wed, 7 Aug 2019 16:06:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qVEuEUp5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67A7921871 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4w1TnibfLf1Ix9lBuqXXjIBSGvMvf2rHIARfKj7CzlE=; b=qVEuEUp508XJK7 gNuC4YE7Ms69v+EazHB7097tuLMevQdK+rRYC0binc4/8b5VUW68OmkI4rqYISFS6DXfFhV09bcyr 3kQCoGrcRSbEm5Wk4UOtLfDojMwM8bPshv9e3RyPRwf1GYSxLMh1HWo/HqB4XaDxR6mc+jcUJJBrY /p8rUDo9l8bapMRtaxhyUWGIxrHj3U7t3cajK3CbEIIkTCO2Am1pjAz+UC4YfmDV/S3ZnyCnFjFMB YNYo1FBxykJ/7748tqyY7aqCGlwCDC3WQeXRG951IURGwt+4CasutqjYQ5AZMuF2kxdxOWafjFjEE S9nm6z9U6SsjSBcTZO8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvOS3-0006M2-7k; Wed, 07 Aug 2019 16:06:11 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvORx-0006LQ-5C for linux-mtd@lists.infradead.org; Wed, 07 Aug 2019 16:06:07 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id F13742000D; Wed, 7 Aug 2019 16:05:53 +0000 (UTC) Date: Wed, 7 Aug 2019 18:05:52 +0200 From: Miquel Raynal To: Greg Ungerer Subject: Re: GPMI iMX6ull timeout on DMA Message-ID: <20190807180552.4d85fe28@xps13> In-Reply-To: References: <89ae32a0-9b19-4735-90eb-4ffa22aad704@kernel.org> <20190729103655.095297a2@xps13> <18734a1d-17d9-d390-58ef-ad8ca1be925f@kernel.org> <20190729144730.4a58de32@xps13> <17b49e7d-ff63-315f-cf12-3474f7228c6d@kernel.org> <781dd4e6-a694-c3e1-ee13-9c5c51598623@kernel.org> <53cb8db7-bcf8-ee7c-84ee-59a14a04aad9@kernel.org> <20190730103822.7576645d@xps13> <0a6afd79-d5ca-24da-a62c-11146a3522f6@kernel.org> <20190731082823.6284f5a9@collabora.com> <20190802145109.00c4a4eb@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_090605_510443_68687A24 X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: s.hauer@pengutronix.de, Boris Brezillon , linux-mtd@lists.infradead.org, Michael Nazzareno Trimarchi , Boris Brezillon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Greg, Greg Ungerer wrote on Mon, 5 Aug 2019 15:51:05 +1000: > Hi Boris, > > On 2/8/19 10:51 pm, Boris Brezillon wrote: > > On Fri, 2 Aug 2019 22:34:57 +1000 > > Greg Ungerer wrote: > >> On 31/7/19 4:28 pm, Boris Brezillon wrote: > >>> On Wed, 31 Jul 2019 12:05:44 +1000 > >>> Greg Ungerer wrote: > >>>> On 30/7/19 6:38 pm, Miquel Raynal wrote: > >>>>> Greg Ungerer wrote on Tue, 30 Jul 2019 16:06:55 +1000: > >>>>>> On 30/7/19 10:41 am, Greg Ungerer wrote: > >>>>>>> On 30/7/19 10:28 am, Greg Ungerer wrote: > >>>>>>>> On 29/7/19 10:47 pm, Miquel Raynal wrote: > >>>>>>>>> Greg Ungerer wrote on Mon, 29 Jul 2019 22:33:56 +1000: > >>>>>>>>>> On 29/7/19 6:36 pm, Miquel Raynal wrote: > >>>>>>>>>>> Greg Ungerer wrote on Mon, 29 Jul 2019 16:41:51 +1000: > >>>>>>> [snip] > >>>> Note that this was generated on a normal boot up (not failure). > >>> > >>> The values looks good. Can you try with the below diff applied? > >>> --->8--- > >>> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > >>> index 334fe3130285..9771f6a82abe 100644 > >>> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > >>> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c > >>> @@ -721,12 +721,10 @@ static void gpmi_nfc_apply_timings(struct gpmi_nand_data *this) > >>> writel(hw->ctrl1n, gpmi_regs + HW_GPMI_CTRL1_SET); > >>> >>> /* Wait 64 clock cycles before using the GPMI after enabling the DLL */ > >>> - dll_wait_time_us = USEC_PER_SEC / hw->clk_rate * 64; > >>> - if (!dll_wait_time_us) > >>> - dll_wait_time_us = 1; > >>> + dll_wait_time_us = DIV_ROUND_UP(USEC_PER_SEC * 64, hw->clk_rate); > >>> >>> /* Wait for the DLL to settle. */ > >>> - udelay(dll_wait_time_us); > >>> + usleep_range(dll_wait_time_us, dll_wait_time_us * 10); > >>> } > >>> >>> static int gpmi_setup_data_interface(struct nand_chip *chip, int chipnr, > >> > >> Eventually it failed, in the same way with with same errors. > >> Took quite a while, over 600 boot cycles. > >> > >> Note also that I had to hand merge the changes, since in 5.1.14 that > >> gpmi_nfc_apply_timings() is in gpmi-lib.c. But it was trivial to do. > > > > Oh well. I guess the next thing to do would be to dump the timing regs > > and clk rate that are set by the bootloader (before the driver override > > them) or those applied by an older kernel (one that didn't have that > > issue). > > Is this useful? > > With attached patch, I get the following dump of the timing > settings in use: > > ... > drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings() > HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) > HW_GPMI_TIMING1=0x00000000 (calculated=0x60000000) > HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) > r->clock[0]=22000000 (calculated=22000000) > random: fast init done > nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xda > nand: Micron MT29F2G08ABAEAWP > nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 > drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings() > HW_GPMI_TIMING0=0x00010203 (calculated=0x00020101) > HW_GPMI_TIMING1=0x00000000 (calculated=0xb0000000) > HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00000000) > r->clock[0]=22000000 (calculated=22000000) > drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c(490): gpmi_nfc_apply_timings() > HW_GPMI_TIMING0=0x00010203 (calculated=0x00010101) > HW_GPMI_TIMING1=0x00000000 (calculated=0xe0000000) > HW_GPMI_CTRL1_SET=0x01c4000c (calculated=0x00c28000) > r->clock[0]=22000000 (calculated=100000000) Why are the registers not updated? Is it the same situation when we get all the failures? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/