From: kbuild test robot <lkp@intel.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: "Latchesar Ionkov" <lucho@ionkov.net>,
"Dave Kleikamp" <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net,
linux-integrity@vger.kernel.org,
"Martin Brandenburg" <martin@omnibond.com>,
samba-technical@lists.samba.org,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Chao Yu" <yuchao0@huawei.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"David Howells" <dhowells@redhat.com>, "Chris Mason" <clm@fb.com>,
"David S. Miller" <davem@davemloft.net>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
ocfs2-devel@oss.oracle.com, "Eric Paris" <eparis@parisplace.org>,
netdev@vger.kernel.org, "Tyler Hicks" <tyhicks@canonical.com>,
linux-afs@lists.infradead.org,
"Mike Marshall" <hubcap@omnibond.com>,
devel@driverdev.osuosl.org, linux-xfs@vger.kernel.org,
"Andreas Gruenbacher" <agruenba@redhat.com>,
"Sage Weil" <sage@redhat.com>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Richard Weinberger" <richard@nod.at>,
"Mark Fasheh" <mark@fasheh.com>,
linux-unionfs@vger.kernel.org, "Hugh Dickins" <hughd@google.com>,
"James Morris" <jmorris@namei.org>,
cluster-devel@redhat.com,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Vyacheslav Dubeyko" <slava@dubeyko.com>,
"Casey Schaufler" <casey@schaufler-ca.com>,
v9fs-developer@lists.sourceforge.net,
"Ilya Dryomov" <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, kernel-team@android.com,
linux-mm@kvack.org, devel@lists.orangefs.org,
"Serge Hallyn" <serge@hallyn.com>,
Ernesto =?unknown-8bit?Q?A=2E_Fern=C3=A1ndez?=
<ernesto.mnd.fernandez@gmail.com>,
"Gao Xiang" <gaoxiang25@huawei.com>,
linux-cifs@vger.kernel.org,
"Eric Van Hensbergen" <ericvh@gmail.com>,
ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org,
"Josef Bacik" <josef@toxicpanda.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
reiserfs-devel@vger.kernel.org, "Tejun Heo" <tj@kernel.org>,
"Joel Becker" <jlbec@evilplan.org>,
linux-mtd@lists.infradead.org, "David Sterba" <dsterba@suse.com>,
"Jaegeuk Kim" <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org, selinux@vger.kernel.org,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Paul Moore" <paul@paul-moore.com>,
linux-nfs@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
"Theodore Ts'o" <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org,
"Stephen Smalley" <sds@tycho.nsa.gov>,
"Mathieu Malaterre" <malat@debian.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Artem Bityutskiy" <dedekind1@gmail.com>,
"Jeff Layton" <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"Mark Salyzyn" <salyzyn@android.com>,
"Steve French" <sfrench@samba.org>,
linux-security-module@vger.kernel.org, kbuild-all@01.org,
"Jan Kara" <jack@suse.com>, "Bob Peterson" <rpeterso@redhat.com>,
"Phillip Lougher" <phillip@squashfs.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Anna Schumaker" <anna.schumaker@netapp.com>,
linux-btrfs@vger.kernel.org,
"Alexander Viro" <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 14 Aug 2019 19:59:57 +0800 [thread overview]
Message-ID: <201908141935.iswsiyzF%lkp@intel.com> (raw)
In-Reply-To: <20190813145527.26289-1-salyzyn@android.com>
[-- Attachment #1: Type: text/plain, Size: 7121 bytes --]
Hi Mark,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc4 next-20190813]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Mark-Salyzyn/Add-flags-option-to-get-xattr-method-paired-to-__vfs_getxattr/20190814-124805
config: nds32-allmodconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/ubifs/xattr.c:326:9: error: conflicting types for 'ubifs_xattr_get'
ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
^~~~~~~~~~~~~~~
In file included from fs/ubifs/xattr.c:46:
fs/ubifs/ubifs.h:2006:9: note: previous declaration of 'ubifs_xattr_get' was here
ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
^~~~~~~~~~~~~~~
fs/ubifs/xattr.c: In function 'xattr_get':
fs/ubifs/xattr.c:678:9: error: too few arguments to function 'ubifs_xattr_get'
return ubifs_xattr_get(inode, name, buffer, size);
^~~~~~~~~~~~~~~
fs/ubifs/xattr.c:326:9: note: declared here
ssize_t ubifs_xattr_get(struct inode *host, const char *name, void *buf,
^~~~~~~~~~~~~~~
fs/ubifs/xattr.c: At top level:
>> fs/ubifs/xattr.c:699:9: error: initialization of 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t, int)' {aka 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned int, int)'} from incompatible pointer type 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t)' {aka 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned int)'} [-Werror=incompatible-pointer-types]
.get = xattr_get,
^~~~~~~~~
fs/ubifs/xattr.c:699:9: note: (near initialization for 'ubifs_user_xattr_handler.get')
fs/ubifs/xattr.c:705:9: error: initialization of 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t, int)' {aka 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned int, int)'} from incompatible pointer type 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t)' {aka 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned int)'} [-Werror=incompatible-pointer-types]
.get = xattr_get,
^~~~~~~~~
fs/ubifs/xattr.c:705:9: note: (near initialization for 'ubifs_trusted_xattr_handler.get')
fs/ubifs/xattr.c:712:9: error: initialization of 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t, int)' {aka 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned int, int)'} from incompatible pointer type 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t)' {aka 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned int)'} [-Werror=incompatible-pointer-types]
.get = xattr_get,
^~~~~~~~~
fs/ubifs/xattr.c:712:9: note: (near initialization for 'ubifs_security_xattr_handler.get')
fs/ubifs/xattr.c: In function 'xattr_get':
fs/ubifs/xattr.c:679:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +699 fs/ubifs/xattr.c
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 669
ade46c3a6029de Richard Weinberger 2016-09-19 670 static int xattr_get(const struct xattr_handler *handler,
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 671 struct dentry *dentry, struct inode *inode,
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 672 const char *name, void *buffer, size_t size)
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 673 {
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 674 dbg_gen("xattr '%s', ino %lu ('%pd'), buf size %zd", name,
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 675 inode->i_ino, dentry, size);
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 676
17ce1eb0b64eb2 Richard Weinberger 2016-07-31 677 name = xattr_full_name(handler, name);
ade46c3a6029de Richard Weinberger 2016-09-19 @678 return ubifs_xattr_get(inode, name, buffer, size);
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 679 }
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 680
ade46c3a6029de Richard Weinberger 2016-09-19 681 static int xattr_set(const struct xattr_handler *handler,
5930122683dff5 Al Viro 2016-05-27 682 struct dentry *dentry, struct inode *inode,
5930122683dff5 Al Viro 2016-05-27 683 const char *name, const void *value,
5930122683dff5 Al Viro 2016-05-27 684 size_t size, int flags)
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 685 {
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 686 dbg_gen("xattr '%s', host ino %lu ('%pd'), size %zd",
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 687 name, inode->i_ino, dentry, size);
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 688
17ce1eb0b64eb2 Richard Weinberger 2016-07-31 689 name = xattr_full_name(handler, name);
17ce1eb0b64eb2 Richard Weinberger 2016-07-31 690
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 691 if (value)
d8db5b1ca9d4c5 Xiaolei Li 2017-06-23 692 return ubifs_xattr_set(inode, name, value, size, flags, true);
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 693 else
ade46c3a6029de Richard Weinberger 2016-09-19 694 return ubifs_xattr_remove(inode, name);
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 695 }
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 696
dfaf8d2aeca482 Ben Dooks 2016-06-21 697 static const struct xattr_handler ubifs_user_xattr_handler = {
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 698 .prefix = XATTR_USER_PREFIX,
ade46c3a6029de Richard Weinberger 2016-09-19 @699 .get = xattr_get,
ade46c3a6029de Richard Weinberger 2016-09-19 700 .set = xattr_set,
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 701 };
2b88fc21cae91e Andreas Gruenbacher 2016-04-22 702
:::::: The code at line 699 was first introduced by commit
:::::: ade46c3a6029dea49dbc6c7734b0f6a78d3f104c ubifs: Export xattr get and set functions
:::::: TO: Richard Weinberger <richard@nod.at>
:::::: CC: Richard Weinberger <richard@nod.at>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52543 bytes --]
[-- Attachment #3: Type: text/plain, Size: 144 bytes --]
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-08-14 12:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 14:55 [PATCH v2] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn
2019-08-14 5:57 ` kbuild test robot
2019-08-14 11:00 ` Jan Kara
2019-08-14 14:54 ` Mark Salyzyn
2019-08-15 15:30 ` Jan Kara
2019-08-14 11:59 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201908141935.iswsiyzF%lkp@intel.com \
--to=lkp@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=asmadeus@codewreck.org \
--cc=casey@schaufler-ca.com \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=davem@davemloft.net \
--cc=dedekind1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=dwmw2@infradead.org \
--cc=ecryptfs@vger.kernel.org \
--cc=eparis@parisplace.org \
--cc=ericvh@gmail.com \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=idryomov@gmail.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@android.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=malat@debian.org \
--cc=mark@fasheh.com \
--cc=martin@omnibond.com \
--cc=miklos@szeredi.hu \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=paul@paul-moore.com \
--cc=phillip@squashfs.org.uk \
--cc=reiserfs-devel@vger.kernel.org \
--cc=richard@nod.at \
--cc=rpeterso@redhat.com \
--cc=sage@redhat.com \
--cc=salyzyn@android.com \
--cc=samba-technical@lists.samba.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=slava@dubeyko.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).