From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DFF9C433FF for ; Wed, 14 Aug 2019 23:34:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C494208C2 for ; Wed, 14 Aug 2019 23:34:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mw0aNIC9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C494208C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UioLKPO/2AZ5kTYSKRUUbkT1n5Dk4nM5eRpQGMtPq9w=; b=mw0aNIC9tNmOo+ wkTNoFayMfp73BB7hdjdEWuARFbg9C3yH9Eqt0WzEsTOQYNE78fmqtPoaGiC5nTUsQOESnDP6u3jk V5cYpMUq5xy25Of/zec3HGyROEaprEtW5Mo8is6NEuLcMu/qqNpmzmTqujSLfI0RqoJNR4ShTxjtl Av8Sx7kX9akeVonSyVR/FsXj6OujhgCpbHN9bP/XSJANzfYl+Ih3MfxTKHsRhPuSisBaCHnw/oLZ4 SEWG9Wz9iFv9aB3WTOjt3USpnUrLXislI8gnpotlxRpz8NsUjqx+LzC3R5iyTFnxYFfTWQlLNAh/0 Ix++plmODX1p5UkWLk3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hy2mt-0008G6-6t; Wed, 14 Aug 2019 23:34:39 +0000 Received: from zeniv.linux.org.uk ([195.92.253.2]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hy2mq-0007wV-EG for linux-mtd@lists.infradead.org; Wed, 14 Aug 2019 23:34:38 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1hy2km-0001Ye-LK; Wed, 14 Aug 2019 23:32:28 +0000 Date: Thu, 15 Aug 2019 00:32:28 +0100 From: Al Viro To: Sascha Hauer Subject: Re: [PATCH 03/11] fs: move __get_super() out of loop Message-ID: <20190814233228.GU1131@ZenIV.linux.org.uk> References: <20190814121834.13983-1-s.hauer@pengutronix.de> <20190814121834.13983-4-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190814121834.13983-4-s.hauer@pengutronix.de> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_163436_477057_91FE3B93 X-CRM114-Status: UNSURE ( 6.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fsdevel@vger.kernel.org, Richard Weinberger , linux-mtd@lists.infradead.org, kernel@pengutronix.de, Jan Kara Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Aug 14, 2019 at 02:18:26PM +0200, Sascha Hauer wrote: > __get_super_thawed() calls __get_super() multiple times. I can't see a case > where __get_super() would return another valid superblock when called > again, so move the call to __get_super() out of the loop. This is done in > preparation for the next patch. How about "someone has come and unmounted the sucker under us"? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/