* [PATCH] mtd: hyperbus: fix dependency and build error
@ 2019-08-13 23:03 Randy Dunlap
2019-08-24 10:48 ` Miquel Raynal
2019-08-29 12:36 ` Miquel Raynal
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2019-08-13 23:03 UTC (permalink / raw)
To: linux-mtd, LKML; +Cc: Geert Uytterhoeven, Vignesh Raghavendra, Miquel Raynal
From: Randy Dunlap <rdunlap@infradead.org>
lib/devres.c, which implements devm_ioremap_resource(), is only built
when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend
on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on
UML builds):
WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
Depends on [n]: MTD [=m] && HAS_IOMEM [=n]
Selected by [m]:
- MTD_HYPERBUS [=m] && MTD [=m]
ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined!
Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/hyperbus/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- lnx-53-rc4.orig/drivers/mtd/hyperbus/Kconfig
+++ lnx-53-rc4/drivers/mtd/hyperbus/Kconfig
@@ -1,5 +1,6 @@
menuconfig MTD_HYPERBUS
tristate "HyperBus support"
+ depends on HAS_IOMEM
select MTD_CFI
select MTD_MAP_BANK_WIDTH_2
select MTD_CFI_AMDSTD
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: hyperbus: fix dependency and build error
2019-08-13 23:03 [PATCH] mtd: hyperbus: fix dependency and build error Randy Dunlap
@ 2019-08-24 10:48 ` Miquel Raynal
2019-08-24 14:15 ` Vignesh Raghavendra
2019-08-29 12:36 ` Miquel Raynal
1 sibling, 1 reply; 4+ messages in thread
From: Miquel Raynal @ 2019-08-24 10:48 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Geert Uytterhoeven, linux-mtd, LKML, Vignesh Raghavendra
Hi Vignesh,
Randy Dunlap <rdunlap@infradead.org> wrote on Tue, 13 Aug 2019 16:03:13
-0700:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> lib/devres.c, which implements devm_ioremap_resource(), is only built
> when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend
> on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on
> UML builds):
>
> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
> Depends on [n]: MTD [=m] && HAS_IOMEM [=n]
> Selected by [m]:
> - MTD_HYPERBUS [=m] && MTD [=m]
>
> ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined!
>
> Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: linux-mtd@lists.infradead.org
> ---
This patch looks like a good candidate for fixes, shall I send a fixes
PR next week with it? (Acked-by wished)
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: hyperbus: fix dependency and build error
2019-08-24 10:48 ` Miquel Raynal
@ 2019-08-24 14:15 ` Vignesh Raghavendra
0 siblings, 0 replies; 4+ messages in thread
From: Vignesh Raghavendra @ 2019-08-24 14:15 UTC (permalink / raw)
To: Miquel Raynal, Randy Dunlap; +Cc: Geert Uytterhoeven, linux-mtd, LKML
Hi Miquel,
On 24-Aug-19 4:18 PM, Miquel Raynal wrote:
> Hi Vignesh,
>
> Randy Dunlap <rdunlap@infradead.org> wrote on Tue, 13 Aug 2019 16:03:13
> -0700:
>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> lib/devres.c, which implements devm_ioremap_resource(), is only built
>> when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend
>> on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on
>> UML builds):
>>
>> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
>> Depends on [n]: MTD [=m] && HAS_IOMEM [=n]
>> Selected by [m]:
>> - MTD_HYPERBUS [=m] && MTD [=m]
>>
>> ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined!
>>
>> Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: linux-mtd@lists.infradead.org
>> ---
>
> This patch looks like a good candidate for fixes, shall I send a fixes
> PR next week with it? (Acked-by wished)
>
Yes, that would be great. I was about to send across patch bundle myself.
Acked-by: Vignesh Raghavendra <vigneshr@ti.com>
Thanks
Vignesh
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: hyperbus: fix dependency and build error
2019-08-13 23:03 [PATCH] mtd: hyperbus: fix dependency and build error Randy Dunlap
2019-08-24 10:48 ` Miquel Raynal
@ 2019-08-29 12:36 ` Miquel Raynal
1 sibling, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2019-08-29 12:36 UTC (permalink / raw)
To: Randy Dunlap, linux-mtd, LKML
Cc: Geert Uytterhoeven, Vignesh Raghavendra, Miquel Raynal
On Tue, 2019-08-13 at 23:03:13 UTC, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> lib/devres.c, which implements devm_ioremap_resource(), is only built
> when CONFIG_HAS_IOMEM is set/enabled, so MTD_HYPERBUS should depend
> on HAS_IOMEM. Fixes a build error and a Kconfig warning (as seen on
> UML builds):
>
> WARNING: unmet direct dependencies detected for MTD_COMPLEX_MAPPINGS
> Depends on [n]: MTD [=m] && HAS_IOMEM [=n]
> Selected by [m]:
> - MTD_HYPERBUS [=m] && MTD [=m]
>
> ERROR: "devm_ioremap_resource" [drivers/mtd/hyperbus/hyperbus-core.ko] undefined!
>
> Fixes: dcc7d3446a0f ("mtd: Add support for HyperBus memory devices")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: linux-mtd@lists.infradead.org
> Acked-by: Vignesh Raghavendra <vigneshr@ti.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-29 12:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-13 23:03 [PATCH] mtd: hyperbus: fix dependency and build error Randy Dunlap
2019-08-24 10:48 ` Miquel Raynal
2019-08-24 14:15 ` Vignesh Raghavendra
2019-08-29 12:36 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).