From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F51C43331 for ; Fri, 6 Sep 2019 07:12:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C45DE218AF for ; Fri, 6 Sep 2019 07:12:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XEOybkRB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C45DE218AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FZhnDfZRk/xZuLqYKagn6rogi7BiYT1BtZOb2+wRQz8=; b=XEOybkRBJvd70j zhlYK+7Ngf3pPXXdO9Ou/dtk6z314IMiajIo6yiwG1z+ZRZWplwFT+cl1QvQM4tRAbsf4DmbGwEuJ I5AJ1UemKgL8dDs+JiSb9E5pF6NLQYQ588vgkEIm0kwbKy44Jxpcxkn/v0LoIjav5uuJl89SzOhdi jnqIWrEQehs971gntEbgJ633gEhYNPNZlDqgQCpvhE8NwdSmaPUymHYQ+RRcArwvzY14E6TFPUqvj 8vj62xBOW9MJpNEpRNd1HHQH2rGriynFK4OwBk4ExxAK28OzwTnSClkeK8tGmBVNBMNiI80Bzzel8 QQR7VQ62uwWhLTCFAzyA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i68Pj-0004N7-S2; Fri, 06 Sep 2019 07:12:11 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i68Pg-0004Mj-DY for linux-mtd@lists.infradead.org; Fri, 06 Sep 2019 07:12:10 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i68PZ-0006ke-Ua; Fri, 06 Sep 2019 09:12:01 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1i68PY-0002oJ-R1; Fri, 06 Sep 2019 09:12:00 +0200 Date: Fri, 6 Sep 2019 09:12:00 +0200 From: Sascha Hauer To: Sean Nyekjaer Subject: Re: [Bug] mtd: rawnand: gpmi Message-ID: <20190906071200.mzaa5tlnpsrylwhj@pengutronix.de> References: <6a333d0f-09b2-d0d1-a3a5-955b31b6291e@geanix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a333d0f-09b2-d0d1-a3a5-955b31b6291e@geanix.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:41:02 up 60 days, 12:51, 77 users, load average: 0.21, 0.17, 0.27 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190906_001208_459177_C9BC0311 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mkl@pengutronix.de, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi, On Thu, Sep 05, 2019 at 10:26:06PM +0200, Sean Nyekjaer wrote: > Hi, > > I have been troubleshooting some CAN problems on our imx6ull with a raw nand > flash. > I normally run with a 4.19 series kernel, but to verify those CAN problems > have been resolved in newer kernels i have been trying ~5.3-rc6. > > But with that kernel i have run into trouble with ubifs, it throws a lot of > errors: > [ 188.384572] Not a node, first 24 bytes: > [ 188.384588] 00000000: ff ff ff 00 00 00 00 e4 03 00 00 a0 81 00 00 01 00 > 00 00 00 00 00 00 00 ........................ > [ 188.402976] UBIFS error (ubi0:8 pid 117): ubifs_read_node: bad node type > (0 but expected 3) > [ 188.411605] UBIFS error (ubi0:8 pid 117): ubifs_read_node: bad node at > LEB 46:49888, LEB mapping status 1 > > I started a bisect from Linux 5.3-rc7 (bad) to 5.2 (good). > And i'm ending up here: > > commit ef347c0cfd619a9251e5a2f9ff72e33650a9bccb (HEAD) > Author: Sascha Hauer > Date: Tue May 21 09:06:43 2019 +0200 Damn it > > mtd: rawnand: gpmi: Implement exec_op > > dmesg on boot: > [ 1.229431] nand: device found, Manufacturer ID: 0x98, Chip ID: 0xdc > [ 1.229472] nand: Toshiba NAND 512MiB 3,3V 8-bit > [ 1.229510] nand: 512 MiB, SLC, erase size: 256 KiB, page size: 4096, OOB 4k page size NAND, I didn't have such a device for testing, so indeed it could be that my patch is broken for 4k NANDs. > size: 128 > [ 1.229547] ------------[ cut here ]------------ > [ 1.229604] WARNING: CPU: 0 PID: 1 at > drivers/mtd/nand/raw/internals.h:114 nand_reset_op+0x198/0x1c0 > [ 1.229633] Modules linked in: This is unrelated. Please cherry-pick: commit b2b5921fe4b363ff29fea9183aca089231a6bafc Author: Sascha Hauer Date: Tue May 21 10:43:35 2019 +0200 mtd: rawnand: initialize ntargets with maxchips > [ 1.231060] ---[ end trace 12b9d19a5aac4c9f ]--- > [ 1.234710] Bad block table not found for chip 0 > [ 1.236076] Bad block table not found for chip 0 > [ 1.236113] Scanning device for bad blocks > [ 1.244907] random: fast init done > [ 1.701764] Bad eraseblock 798 at 0x00000c780000 > [ 2.132734] Bad eraseblock 1536 at 0x000018000000 > [ 2.133094] Bad eraseblock 1537 at 0x000018040000 > [ 2.434057] Bad block table written to 0x00001ffc0000, version 0x01 > [ 2.437254] Bad block table written to 0x00001ff80000, version 0x01 I assume your device had a bbt before, right? In that case we won't have to go down to UBI, even a plain read seems to be broken. Could you dump some NAND page with and without ef347c0cfd619a and see if and how they are different? Something like "nanddump -c -l 4096 /dev/mtdx" should do it. Maybe you have to adjust the starting address with the -s option to get some page with data. Also you could try the mtd test modules to see if tests fail. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/