From: Bastian Germann <bastiangermann@fishpost.de>
To: linux-mtd@lists.infradead.org
Cc: Bastian Germann <bastiangermann@fishpost.de>
Subject: [PATCH] ubiupdatevol: Prevent null pointer dereference
Date: Sun, 8 Sep 2019 21:59:22 +0200 [thread overview]
Message-ID: <20190908195922.23643-1-bastiangermann@fishpost.de> (raw)
libubi_close(libubi) is called in the error handler if libubi is null.
Prevent that by handling the error case similar to the other ubi
executables.
Signed-off-by: Bastian Germann <bastiangermann@fishpost.de>
---
ubi-utils/ubiupdatevol.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/ubi-utils/ubiupdatevol.c b/ubi-utils/ubiupdatevol.c
index bdcc091..1b3239e 100644
--- a/ubi-utils/ubiupdatevol.c
+++ b/ubi-utils/ubiupdatevol.c
@@ -308,9 +308,7 @@ int main(int argc, char * const argv[])
if (!libubi) {
if (errno == 0)
errmsg("UBI is not present in the system");
- else
- sys_errmsg("cannot open libubi");
- goto out_libubi;
+ return sys_errmsg("cannot open libubi");
}
err = ubi_probe_node(libubi, args.node);
--
2.23.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next reply other threads:[~2019-09-08 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 19:59 Bastian Germann [this message]
2019-09-10 8:19 ` [PATCH] ubiupdatevol: Prevent null pointer dereference David Oberhollenzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908195922.23643-1-bastiangermann@fishpost.de \
--to=bastiangermann@fishpost.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).