From: Greg KH <greg@kroah.com>
To: Tokunori Ikegami <ikegami.t@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Hauke Mehrtens <hauke@hauke-m.de>,
stable@vger.kernel.org,
Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-mtd@lists.infradead.org, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH for 5.2.y] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword()
Date: Mon, 23 Sep 2019 09:13:46 +0200 [thread overview]
Message-ID: <20190923071346.GD2746429@kroah.com> (raw)
In-Reply-To: <20190923023251.20180-1-ikegami.t@gmail.com>
On Mon, Sep 23, 2019 at 11:32:51AM +0900, Tokunori Ikegami wrote:
> As reported by the OpenWRT team, write requests sometimes fail on some
> platforms.
> Currently to check the state chip_ready() is used correctly as described by
> the flash memory S29GL256P11TFI01 datasheet.
> Also chip_good() is used to check if the write is succeeded and it was
> implemented by the commit fb4a90bfcd6d8 ("[MTD] CFI-0002 - Improve error
> checking").
> But actually the write failure is caused on some platforms and also it can
> be fixed by using chip_good() to check the state and retry instead.
> Also it seems that it is caused after repeated about 1,000 times to retry
> the write one word with the reset command.
> By using chip_good() to check the state to be done it can be reduced the
> retry with reset.
> It is depended on the actual flash chip behavior so the root cause is
> unknown.
>
> Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> Cc: linux-mtd@lists.infradead.org
> Cc: stable@vger.kernel.org
> Reported-by: Fabio Bettoni <fbettoni@gmail.com>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
> [vigneshr@ti.com: Fix a checkpatch warning]
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> drivers/mtd/chips/cfi_cmdset_0002.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
What is the git commit id of this patch in Linus's tree?
thanks,
greg k-h
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-09-23 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 2:32 [PATCH for 5.2.y] mtd: cfi_cmdset_0002: Use chip_good() to retry in do_write_oneword() Tokunori Ikegami
2019-09-23 7:13 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-17 17:50 Tokunori Ikegami
2019-09-17 18:11 ` Greg KH
2019-09-17 22:32 ` Tokunori Ikegami
2019-09-18 5:52 ` Greg KH
2019-09-18 13:59 ` Tokunori Ikegami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923071346.GD2746429@kroah.com \
--to=greg@kroah.com \
--cc=Joakim.Tjernlund@infinera.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=hauke@hauke-m.de \
--cc=ikegami.t@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nbd@nbd.name \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).