From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C386C10F14 for ; Thu, 10 Oct 2019 07:17:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AFDB2067B for ; Thu, 10 Oct 2019 07:17:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qG3aVCTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AFDB2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mGUVdLd+FV4/DIGGux+a8MdAgOdFr9cwrdF2XXa+WJc=; b=qG3aVCTkmgvYwh 6ehKIjY/otsrjXJAosuacLbvLSY8gdTqcJvxltjq0ui/ErAdRcq3qMc1MpP4XlK5+CsQfIn/TscEv 1XXEjp1j4LOaPOu2I5JaShoBbqzbfzdBRXlOGhC9qm5o3Q6ILyDsxMCI57IagmR0un69sQCwo0twA VYOd122d63vlWWgOD6CzjatJ5NMKgeGaHbkTv/ztUXxoZaB40H4Cw3p2tnAYSB/Ws3A1SNEogAEgs MALE/l0y0LLkJ9gzBCXvLPE0cyMFqeXse5VR8skmtxvtdXvq2Xr9K5HwTjE39a4MaKzRun4MwdXS4 fdyj2lo3bG0QFPctMQAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIShA-0004q3-IC; Thu, 10 Oct 2019 07:17:08 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISgt-0004cs-RG; Thu, 10 Oct 2019 07:16:53 +0000 Received: from dhcp-172-31-174-146.wireless.concordia.ca (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 3838A28EBEA; Thu, 10 Oct 2019 08:16:50 +0100 (BST) Date: Thu, 10 Oct 2019 09:16:48 +0200 From: Boris Brezillon To: Subject: Re: [PATCH v2 07/22] mtd: spi-nor: Rework read_cr() Message-ID: <20191010091648.10d9a993@dhcp-172-31-174-146.wireless.concordia.ca> In-Reply-To: <20190924074533.6618-8-tudor.ambarus@microchip.com> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-8-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_001652_012691_C7ACE246 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, geert+renesas@glider.be, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, marek.vasut@gmail.com, jonas@norrbonn.se, linux-mtd@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-aspeed@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 24 Sep 2019 07:46:15 +0000 wrote: > From: Tudor Ambarus > > static int read_cr(struct spi_nor *nor) > becomes > static int spi_nor_read_cr(struct spi_nor *nor, u8 *cr) > > The new function returns 0 on success and -errno otherwise. > We let the callers pass the pointer to the buffer where the > value of the Configuration Register will be written. This way > we avoid the casts between int and u8, which can be confusing. > > Prepend spi_nor_ to the function name, all functions should begin > with that. > Same as for patch 5, this should be split in several patches > Vendors are using both the "Configuration Register" and the > "Status Register 2" terminology when referring to the second byte > of the Status Register. Indicate in the description of the function > that we use the SPINOR_OP_RDCR (35h) command to interrogate the ^query > Configuration Register. > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37184C10F14 for ; Thu, 10 Oct 2019 07:17:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E96AA2067B for ; Thu, 10 Oct 2019 07:17:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PhFh/+QB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E96AA2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U/K/If1Y3G+SmausuEB/EM+ZjYqWLdrZgpTKoxHn1YM=; b=PhFh/+QBt4HBr3 tpifJADrS+IMXvBg4DO3XDR9+O7xFOMsKXlDY/tc8LNBBZaJSdY7Z4zg/K6X6k7EqV5OsyfpXwXz2 E0y1lWI2oD43gN/vl/9Nq8Zv1YOFgnHR60FEaJYJosR4pTfH4y5uWJK/5uXJwbfyWn+9RtAUKe8eT YGn2dUnoAeZJ2pIiLzCjVcENY3MEbHX0KfRoW7Lg6f9BVZxI7xEETEJsXgwi996ZmxUMAo5csU9Uw S8kcjcwi6i9wnTMpSUXWxeuczKs/wq9BSx5HoY882ADq1lste2Qp1OStCj9pzFIY6GsiocG6hA7M8 aZ8bY9u1jD9XtwWdXbiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIShd-0005KP-Sx; Thu, 10 Oct 2019 07:17:37 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISh1-0004ih-SH; Thu, 10 Oct 2019 07:17:01 +0000 Received: from dhcp-172-31-174-146.wireless.concordia.ca (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id AEEFF290694; Thu, 10 Oct 2019 08:16:57 +0100 (BST) Date: Thu, 10 Oct 2019 09:16:54 +0200 From: Boris Brezillon To: Subject: Re: [PATCH v2 07/22] mtd: spi-nor: Rework read_cr() Message-ID: <20191010091648.10d9a993@dhcp-172-31-174-146.wireless.concordia.ca> In-Reply-To: <20190924074533.6618-8-tudor.ambarus@microchip.com> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-8-tudor.ambarus@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_001700_454206_E32D6CF8 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, geert+renesas@glider.be, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, marek.vasut@gmail.com, jonas@norrbonn.se, linux-mtd@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-aspeed@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Message-ID: <20191010071654.nhL1LGEQWdWYbFklVq-54S2qmH7d4EH-N21o3GEImx8@z> On Tue, 24 Sep 2019 07:46:15 +0000 wrote: > From: Tudor Ambarus > > static int read_cr(struct spi_nor *nor) > becomes > static int spi_nor_read_cr(struct spi_nor *nor, u8 *cr) > > The new function returns 0 on success and -errno otherwise. > We let the callers pass the pointer to the buffer where the > value of the Configuration Register will be written. This way > we avoid the casts between int and u8, which can be confusing. > > Prepend spi_nor_ to the function name, all functions should begin > with that. > Same as for patch 5, this should be split in several patches. > Vendors are using both the "Configuration Register" and the > "Status Register 2" terminology when referring to the second byte > of the Status Register. Indicate in the description of the function > that we use the SPINOR_OP_RDCR (35h) command to interrogate the ^query > Configuration Register. > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/