From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: maps: l440gx: Avoid print address to dmesg
Date: Thu, 10 Oct 2019 10:26:06 +0200 [thread overview]
Message-ID: <20191010102606.253ff6b9@xps13> (raw)
In-Reply-To: <20191010080130.25402-1-huangfq.daxian@gmail.com>
Hi Fuqian,
Fuqian Huang <huangfq.daxian@gmail.com> wrote on Thu, 10 Oct 2019
16:01:30 +0800:
> Avoid print the address of l440gx_map.virt every time l440gx init.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/mtd/maps/l440gx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/maps/l440gx.c b/drivers/mtd/maps/l440gx.c
> index 876f12f40018..e7e40bca82d1 100644
> --- a/drivers/mtd/maps/l440gx.c
> +++ b/drivers/mtd/maps/l440gx.c
> @@ -86,7 +86,6 @@ static int __init init_l440gx(void)
> return -ENOMEM;
> }
> simple_map_init(&l440gx_map);
> - printk(KERN_NOTICE "window_addr = 0x%08lx\n", (unsigned long)l440gx_map.virt);
>
> /* Setup the pm iobase resource
> * This code should move into some kind of generic bridge
It looks more like a debug message, maybe turn it into a KERN_DEBUG?
Usually people do not run their kernels with such a low trace limit.
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-10-10 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 8:01 [PATCH] mtd: maps: l440gx: Avoid print address to dmesg Fuqian Huang
2019-10-10 8:26 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010102606.253ff6b9@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=huangfq.daxian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).