From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277E2CA9EAF for ; Thu, 24 Oct 2019 06:05:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE60A20856 for ; Thu, 24 Oct 2019 06:05:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JDXIChW9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE60A20856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GHMTstVfc009fPt7/DD2nJYTD3ewfTxVTvdF3Xq4Hro=; b=JDXIChW9YX5I+c 6ZDpMtl3rrq3h4hpii3qofzJgNx0qYu8Wj05w2jugDSR+PL4XU0HjORU94aHQXDFJfhbfVV5aE7bn 2OMqGNaZr0qJ+ekMp4qbeAUmOuuSLMl1Yf8Rq8k/ERyoT5sJbePpT07e39wTZGHBNKJlUlS67H4BV RPFRKKhFvhxywG5vU21PhPCt5JFf4wnBCp0OuCdP6vNnu3p0e58AA9kwi/FkRpAgFiKummBaTLLOE G2PLJ6fAfhI4vjc9/v7S9vkHECuckUZnFQhbJVK2oK6kwn5U0myoqTexkPEGGXrcEoeUVdjpVMIMh d2YSr68nkDQz9AanBbIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNWFP-0006eQ-9t; Thu, 24 Oct 2019 06:05:23 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNWF2-0005C4-95; Thu, 24 Oct 2019 06:05:01 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id C115128F789; Thu, 24 Oct 2019 07:04:56 +0100 (BST) Date: Thu, 24 Oct 2019 08:04:52 +0200 From: Boris Brezillon To: Subject: Re: [PATCH v2 08/22] mtd: spi-nor: Rework write_enable/disable() Message-ID: <20191024080452.522b6447@collabora.com> In-Reply-To: <34fbb0d7-ee8f-a6d7-4a3e-d64f2f8555ff@microchip.com> References: <20190924074533.6618-1-tudor.ambarus@microchip.com> <20190924074533.6618-9-tudor.ambarus@microchip.com> <20191010092117.4c5018a8@dhcp-172-31-174-146.wireless.concordia.ca> <34fbb0d7-ee8f-a6d7-4a3e-d64f2f8555ff@microchip.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_230500_450884_7EECA309 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vigneshr@ti.com, geert+renesas@glider.be, andrew@aj.id.au, richard@nod.at, linux-kernel@vger.kernel.org, vz@mleia.com, marek.vasut@gmail.com, jonas@norrbonn.se, linux-mtd@lists.infradead.org, joel@jms.id.au, miquel.raynal@bootlin.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, linux-aspeed@lists.ozlabs.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, 23 Oct 2019 23:39:31 +0000 wrote: > On 10/10/2019 10:21 AM, Boris Brezillon wrote: > > External E-Mail > > > > > > On Tue, 24 Sep 2019 07:46:18 +0000 > > wrote: > > > >> From: Tudor Ambarus > >> > >> static int write_enable(struct spi_nor *nor) > >> static int write_disable(struct spi_nor *nor) > >> become > >> static int spi_nor_write_enable(struct spi_nor *nor) > >> static int spi_nor_write_disable(struct spi_nor *nor) > >> > >> Check for errors after each call to them. Move them up in the > >> file as the first SPI NOR Register Operations, to avoid further > >> forward declarations. > > > > Same here, split that in 3 patches please. In order to keep the number of patch in this series small, I'd recommend doing all spi_nor_ prefixing in a patch, all function moves in another one and all error checking in a third patch, instead of splitting it per-function. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/