From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF634C47E49 for ; Wed, 30 Oct 2019 15:27:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6610820679 for ; Wed, 30 Oct 2019 15:27:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ub4Mkmd6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6610820679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KleGZlkAduHTgeONrJKCUMESz28s7fWjCqAsEhNY1Aw=; b=ub4Mkmd6CflroA vmeiG/SJ47jg+xAAaLKNLq+ptFNtDueed5bq+WM8xJ6NKASSGpafmctFB2sHOhwEouq6pNJW+vx82 85wKeV4xNbY+Y7mc6DdbwmLaOHmlLv7vJXabrb8ofR5I+3VfuThTyW7CFsuafr2rlmaeC04skrz0r 9NYN8UnidUbNlw1EkhTgRh8JLGyEfLgEKerehcG9SLEtr/IECw1KjqOSES/g0qHgTwkJKJEyhOCjH GQrxrZ6HGqujIvNWa3ssOp1XWcm0pvj8YZt2CilZJthhb47XjJWH4KVW2L5Yc2IXjFaCxTNxiOQtP pyBtdJph9lTD0vpVPQKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPpt8-0006H5-8q; Wed, 30 Oct 2019 15:27:58 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPpsQ-0005bO-HO for linux-mtd@lists.infradead.org; Wed, 30 Oct 2019 15:27:16 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iPpsG-0003Xy-Om; Wed, 30 Oct 2019 16:27:04 +0100 Received: from sha by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1iPpsF-0005n2-QI; Wed, 30 Oct 2019 16:27:03 +0100 From: Sascha Hauer To: linux-fsdevel@vger.kernel.org Subject: [PATCH v2 00/10] Add quota support to UBIFS Date: Wed, 30 Oct 2019 16:26:52 +0100 Message-Id: <20191030152702.14269-1-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.24.0.rc1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191030_082714_616760_77E1A11C X-CRM114-Status: GOOD ( 19.10 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , Sascha Hauer , linux-mtd@lists.infradead.org, kernel@pengutronix.de, Jan Kara Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org This series adds quota support to UBIFS. It's been a while since I last time posted this series. Here's an update with the review feedback I received integrated. There are quite some if(!inode) sprinkled in the quota code, maybe this could be done more clever. I think this series is a good improvement to the last one I sent though, so I decided to send it out like this for now. This series follows a very simple approach to quota: Neither the quota limits nor the quota usage are ever written to the medium. The quota usage is reconstructed from the filesystem during mount time. The quota limits must be set by the user each time after mount. This is probably not very convenient for systems that are used interactively, but UBIFS is targetted to embedded systems and here running a script after mount shouldn't be a problem. This of course isn't the way quota was thought to be, but I believe this is a good compromise for a feature that I predict is only rarely used on UBIFS. The big upside of this approach is that no on-disk format changes are required and thus we can't get any broken/corrupt filesystems because of quota support. Reconstructing the quota data each time during mount has an noticable but I think for many cases acceptable time overhead. I mounted a ~56MiB rootfs with 1920 files which takes around 0.7s longer when quota is enabled. As UBIFS works on mtd there is no block_device involved. The quotactl system call requires a path to a block device as argument. To overcome this we add support for passing the mount point instead. This is done with a new Q_PATH flag to the quotactl syscall indicating that the special argument belongs to the mount path rather than a path to the block device file The UBIFS quota support itself is based on a series by Dongsheng Yang posted here: http://lists.infradead.org/pipermail/linux-mtd/2015-September/061812.html This part hasn't changed much, except that the code for reading and writing quota files has been dropped. Sascha Changes since v1: - Introduce Q_PATH flag to make passing a mountpath explicit - Do not mess with fs layer as suggested by Al Viro - create separate usrquota, grpquota and prjquota options rather than just a single quota option - register a UBIFS specific quota_format and use dquot_enable() - drop "quota: Only module_put the format when existing" which is no longer necesary Sascha Hauer (10): quota: Make inode optional quota: Pass sb to vfs_load_quota_inode() quota: Introduce dquot_enable_sb() quota: Allow to pass mount path to quotactl ubifs: move checks and preparation into setflags() ubifs: Add support for FS_IOC_FS[SG]ETXATTR ioctls ubifs: do not ubifs_inode() on potentially NULL pointer ubifs: Add support for project id ubifs: export get_znode ubifs: Add quota support Documentation/filesystems/ubifs.txt | 7 +- fs/quota/dquot.c | 66 ++- fs/quota/quota.c | 37 +- fs/ubifs/Makefile | 1 + fs/ubifs/dir.c | 31 +- fs/ubifs/file.c | 43 ++ fs/ubifs/ioctl.c | 222 +++++++++- fs/ubifs/journal.c | 4 +- fs/ubifs/quota.c | 609 ++++++++++++++++++++++++++++ fs/ubifs/super.c | 83 +++- fs/ubifs/tnc.c | 34 +- fs/ubifs/ubifs-media.h | 6 +- fs/ubifs/ubifs.h | 42 ++ include/linux/quotaops.h | 2 + include/uapi/linux/quota.h | 2 + 15 files changed, 1110 insertions(+), 79 deletions(-) create mode 100644 fs/ubifs/quota.c -- 2.24.0.rc1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/